mirrors/crowdsec
1
0
Fork 0
mirror of https://github.com/crowdsecurity/crowdsec.git synced 2025-05-13 05:15:58 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

lint/nestif: reduce hubtest complexity (#3244)

Browse source
This commit is contained in:
mmetc 2024-09-19 16:59:02 +02:00 • committed by GitHub
parent 29f3d2710d
commit 00032d40a8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 43 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.golangci.yml
View file

@ -27,7 +27,7 @@ linters-settings:
nestif: nestif:
# lower this after refactoring # lower this after refactoring
min-complexity: 19 min-complexity: 16
nlreturn: nlreturn:
block-size: 5 block-size: 5

66
cmd/crowdsec-cli/clihubtest/run.go
View file

@ -56,6 +56,46 @@ func (cli *cliHubTest) run(runAll bool, nucleiTargetHost string, appSecHost stri
return nil return nil
} }
func printParserFailures(test *hubtest.HubTestItem) {
if len(test.ParserAssert.Fails) == 0 {
return
}
fmt.Println()
log.Errorf("Parser test '%s' failed (%d errors)\n", test.Name, len(test.ParserAssert.Fails))
for _, fail := range test.ParserAssert.Fails {
fmt.Printf("(L.%d) %s => %s\n", fail.Line, emoji.RedCircle, fail.Expression)
fmt.Printf(" Actual expression values:\n")
for key, value := range fail.Debug {
fmt.Printf(" %s = '%s'\n", key, strings.TrimSuffix(value, "\n"))
}
fmt.Println()
}
}
func printScenarioFailures(test *hubtest.HubTestItem) {
if len(test.ScenarioAssert.Fails) == 0 {
return
}
fmt.Println()
log.Errorf("Scenario test '%s' failed (%d errors)\n", test.Name, len(test.ScenarioAssert.Fails))
for _, fail := range test.ScenarioAssert.Fails {
fmt.Printf("(L.%d) %s => %s\n", fail.Line, emoji.RedCircle, fail.Expression)
fmt.Printf(" Actual expression values:\n")
for key, value := range fail.Debug {
fmt.Printf(" %s = '%s'\n", key, strings.TrimSuffix(value, "\n"))
}
fmt.Println()
}
}
func (cli *cliHubTest) newRunCmd() *cobra.Command { func (cli *cliHubTest) newRunCmd() *cobra.Command {
var ( var (
noClean bool noClean bool
@ -111,30 +151,8 @@ func (cli *cliHubTest) newRunCmd() *cobra.Command {
success = false success = false
cleanTestEnv := false cleanTestEnv := false
if cfg.Cscli.Output == "human" { if cfg.Cscli.Output == "human" {
if len(test.ParserAssert.Fails) > 0 { printParserFailures(test)
fmt.Println() printScenarioFailures(test)
log.Errorf("Parser test '%s' failed (%d errors)\n", test.Name, len(test.ParserAssert.Fails))
for _, fail := range test.ParserAssert.Fails {
fmt.Printf("(L.%d) %s => %s\n", fail.Line, emoji.RedCircle, fail.Expression)
fmt.Printf(" Actual expression values:\n")
for key, value := range fail.Debug {
fmt.Printf(" %s = '%s'\n", key, strings.TrimSuffix(value, "\n"))
}
fmt.Println()
}
}
if len(test.ScenarioAssert.Fails) > 0 {
fmt.Println()
log.Errorf("Scenario test '%s' failed (%d errors)\n", test.Name, len(test.ScenarioAssert.Fails))
for _, fail := range test.ScenarioAssert.Fails {
fmt.Printf("(L.%d) %s => %s\n", fail.Line, emoji.RedCircle, fail.Expression)
fmt.Printf(" Actual expression values:\n")
for key, value := range fail.Debug {
fmt.Printf(" %s = '%s'\n", key, strings.TrimSuffix(value, "\n"))
}
fmt.Println()
}
}
if !forceClean && !noClean { if !forceClean && !noClean {
prompt := &survey.Confirm{ prompt := &survey.Confirm{
Message: fmt.Sprintf("\nDo you want to remove runtime folder for test '%s'? (default: Yes)", test.Name), Message: fmt.Sprintf("\nDo you want to remove runtime folder for test '%s'? (default: Yes)", test.Name),