mirror of
https://github.com/crowdsecurity/crowdsec.git
synced 2025-05-10 20:05:55 +02:00
ignore zero value variables for context (#3436)
This commit is contained in:
parent
6827f065fa
commit
763959fb68
2 changed files with 51 additions and 0 deletions
|
@ -4,6 +4,7 @@ import (
|
|||
"encoding/json"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"reflect"
|
||||
"slices"
|
||||
"strconv"
|
||||
|
||||
|
@ -202,6 +203,10 @@ func EvalAlertContextRules(evt types.Event, match *types.MatchedRule, request *h
|
|||
}
|
||||
}
|
||||
default:
|
||||
r := reflect.ValueOf(output)
|
||||
if r.IsZero() || r.IsNil() {
|
||||
continue
|
||||
}
|
||||
val := fmt.Sprintf("%v", output)
|
||||
if val != "" && !slices.Contains(tmpContext[key], val) {
|
||||
tmpContext[key] = append(tmpContext[key], val)
|
||||
|
|
|
@ -363,3 +363,49 @@ func TestAppsecEventToContext(t *testing.T) {
|
|||
assert.ElementsMatch(t, test.expectedResult, metas)
|
||||
}
|
||||
}
|
||||
|
||||
func TestEvalAlertContextRules(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
contextToSend map[string][]string
|
||||
event types.Event
|
||||
match types.MatchedRule
|
||||
req *http.Request
|
||||
expectedResult map[string][]string
|
||||
expectedErrLen int
|
||||
}{
|
||||
{
|
||||
name: "no appsec match",
|
||||
contextToSend: map[string][]string{
|
||||
"source_ip": {"evt.Parsed.source_ip"},
|
||||
"id": {"match.id"},
|
||||
},
|
||||
event: types.Event{
|
||||
Parsed: map[string]string{
|
||||
"source_ip": "1.2.3.4",
|
||||
"source_machine": "mymachine",
|
||||
"uri": "/test/test/test/../../../../../../../../",
|
||||
},
|
||||
},
|
||||
expectedResult: map[string][]string{
|
||||
"source_ip": {"1.2.3.4"},
|
||||
"id": {},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
for _, test := range tests {
|
||||
t.Run(test.name, func(t *testing.T) {
|
||||
contextDict := make(map[string][]string)
|
||||
|
||||
alertContext = Context{}
|
||||
if err := NewAlertContext(test.contextToSend, 100); err != nil {
|
||||
t.Fatalf("failed to compile %s: %s", test.name, err)
|
||||
}
|
||||
|
||||
errs := EvalAlertContextRules(test.event, &test.match, test.req, contextDict)
|
||||
assert.Len(t, errs, test.expectedErrLen)
|
||||
assert.Equal(t, test.expectedResult, contextDict)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue