lint: enable (some) gocritic checks (#3238)

* lint: gocritic configuration
* lint: octal literals
* lint: gocritic (filepath.Join)
* ling: gocritic (badRegexp, regexpSimplify)
* lint: gocritic (preferStringWriter)
* lint: gocritic (emtpyStringTest)
* filepath.Clean(a+b) -> filepath.Join(a, b)
* gofumpt
This commit is contained in:
mmetc 2024-09-17 17:07:30 +02:00 committed by GitHub
parent 5f22c78fcf
commit b93b240bd4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
45 changed files with 143 additions and 131 deletions

View file

@ -21,7 +21,7 @@ func TestListFilesAtPath(t *testing.T) {
require.NoError(t, err)
_, err = os.Create(filepath.Join(dir, "slack"))
require.NoError(t, err)
err = os.Mkdir(filepath.Join(dir, "somedir"), 0755)
err = os.Mkdir(filepath.Join(dir, "somedir"), 0o755)
require.NoError(t, err)
_, err = os.Create(filepath.Join(dir, "somedir", "inner"))
require.NoError(t, err)