lint/deep-exit: avoid log.Fatal (#3367)

* lint/deep-exit: don't fail on invalid alert
* lint/deep-exit: kinesis_test.go
* lint/deep-exit: watcher_test.go
* lint/deep-exit: parsing_test.go
* lint/deep-exit: client_test.go
This commit is contained in:
mmetc 2024-12-18 16:43:19 +01:00 committed by GitHub
parent 2c95a24f69
commit ecf34c2fa1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 87 additions and 126 deletions

View file

@ -363,10 +363,7 @@ func NewAlert(leaky *Leaky, queue *types.Queue) (types.RuntimeAlert, error) {
}
if err := newApiAlert.Validate(strfmt.Default); err != nil {
log.Errorf("Generated alerts isn't valid")
log.Errorf("->%s", spew.Sdump(newApiAlert))
// XXX: deep-exit - note other errors returned from this function are not fatal
log.Fatalf("error : %s", err)
return runtimeAlert, fmt.Errorf("invalid generated alert: %w: %s", err, spew.Sdump(newApiAlert))
}
runtimeAlert.APIAlerts = append(runtimeAlert.APIAlerts, newApiAlert)