mmetc
8a259fd25b
lint (copyloopvar) ( #2971 )
2024-06-20 22:13:26 +02:00
mmetc
a1ebe18221
config: expand env variables in local_api_credentials.yaml and .yaml.local ( #3093 )
...
* config: expand env variables in local_api_credentials.yaml and .yaml.local
* fix func test
2024-06-20 17:18:41 +02:00
mmetc
659774fd3d
refactor: prefer logrus.WithField over WithFields with a single param ( #3087 )
2024-06-20 10:38:23 +02:00
mmetc
4521a98ecc
db: don't set machine heartbeat until first connection ( #3019 )
...
* db: don't set machine heartbeat until first connection
* cscli machines prune: if hearbeat is not set, look at creation date
* lint
2024-06-17 10:39:50 +02:00
mmetc
44a2014f62
db: don't set bouncer last_pull until first connection ( #3020 )
...
* db: don't set bouncer last_pull until first connection
* cscli bouncers prune: query creation date if they never connected
2024-06-17 10:16:46 +02:00
mmetc
e6ebf7af22
enable linter: revive (superfluous-else) ( #3082 )
...
* enable linter: revive (superfluous-else)
* lint (whitespace)
2024-06-13 11:33:01 +02:00
mmetc
2f6d4cccd7
cscli: refactor hubtests / extract methods run(), coverage() ( #3086 )
2024-06-13 11:17:27 +02:00
mmetc
a529e66cd8
Typos ( #3084 )
...
* comment fix
* redundancy
* typo nill -> nil
* remove extra newline from log
2024-06-13 11:07:44 +02:00
mmetc
4e09ae2182
cscli: fixed some inconsistency in returning errors ( #3076 )
2024-06-12 13:06:44 +02:00
mmetc
e859a751e9
lint: disable redundant linters, update revive configuration and code metrics ( #3081 )
2024-06-12 13:04:47 +02:00
mmetc
73792eacb6
refactor pkg/parser: extract processGrok ( #3080 )
...
* pkg/parser: extract method processGrok()
* early return
* early return/2
2024-06-12 11:49:19 +02:00
mmetc
fd433a7e73
cscli: refactor "cscli setup" to avoid global variable ( #3075 )
...
* cscli refactor: extract method cliSetup.detect()
* cscli refactor: extract method cliSetup.install()
* cscli refactor: extract method cliSetup.dataSources()
* cscli refactor: method ccliSetup.validate()
* skip redundant pre-loop checks
2024-06-12 11:07:10 +02:00
mmetc
bd4540b1bf
refactor context (cscli, pkg/database) ( #3071 )
...
* cscli: helper require.DBClient()
* refactor pkg/database: explicit context to dbclient constructor
* lint
2024-06-11 12:13:18 +02:00
Laurence Jones
24687e982a
enhancement: add deprecation notice to cscli dashboard prerun ( #3079 )
2024-06-11 09:34:37 +01:00
mmetc
1d08edc200
enable linter: revive (deep-exit) ( #3077 )
2024-06-11 09:32:20 +02:00
mmetc
c39c9cf8b7
cscli: fix deprecation message for "context delete" ( #3078 )
...
missing newline, proper return code, same msg as dashboard, test
2024-06-11 09:28:10 +02:00
mmetc
ae58b158a5
enable linter: revive (var-declaration) ( #3069 )
2024-06-11 09:26:50 +02:00
mmetc
31ed9fb5ee
enable linter: revive (indent-error-flow) ( #3068 )
...
* enable linter: revive (indent-error-flow)
* lint
2024-06-10 17:36:22 +02:00
mmetc
7fd01ae3fc
CI: update golangci-lint to 1.59; enforce canonical HTTP headers ( #3074 )
2024-06-10 16:13:49 +02:00
Laurence Jones
819fa0ee22
enhancement: add other log levels to docker start script and document them ( #3072 )
2024-06-10 10:09:10 +01:00
mmetc
13fb252571
lint: replace cyclop, gocyclo with revive; basic pkg/hubtest helper ( #3065 )
2024-06-07 19:03:23 +02:00
mmetc
dd6cf2b844
pkg/cwhub: use explicit context for item install, upgrade ( #3067 )
2024-06-07 17:32:52 +02:00
mmetc
cad760e605
pkg/cwhub: use explicit context for version check, index update ( #3064 )
...
* cscli refactor: explicit context for hub (version lookup)
* change order of version checks
* pkg/cwhub: split NewHub() + Update() + Load()
* cscli refactor: explicit context for hub (index update)
* updated pkg/cwhub docs
* lint
2024-06-07 16:56:02 +02:00
mmetc
72b6da9925
enable linter: revive (early-return) ( #3051 )
...
* enable linter: revive (early-return)
* lint
2024-06-07 16:53:23 +02:00
MazzMa
d3974894fc
add: go reference badge ( #3066 )
2024-06-07 15:58:16 +02:00
mmetc
550d422d23
lint revive(deep-exit): refactor cmd/crowdsec ( #3063 )
...
* lint revive(deep-exit): refactor cmd/crowdsec
* lint
2024-06-07 12:01:08 +02:00
mmetc
6ef2396c91
enable linter: revive (blank-imports) ( #3062 )
...
* lint: revive (blank-imports) require a comment to justify blank imports
* typo
2024-06-06 16:03:32 +02:00
mmetc
7d75290a0f
Use cmp.Or from go 1.22 ( #3058 )
2024-06-06 14:53:30 +02:00
mmetc
b38b959f71
enable linter "stylecheck" ( #3060 )
...
* enable linter "stylecheck"
* stylecheck: omit redundant types
2024-06-06 14:51:49 +02:00
Manuel Sabban
1378e16578
fix test 01_cscli by avoiding discrepancies in cscli explain ( #3059 )
...
* fix hub installed items in pacakge tests
2024-06-06 11:19:05 +02:00
mmetc
114a966129
refactor "cscli decisions" ( #3061 )
...
* cscli decisions: extract method add()
* cscli decisions: extract method delete()
* cscli lapi: avoid apiclient global
* cscli capi: avoid apiclient global
* cscli decisions: error cleanup, avoid global for api client
* update test
* cscli alerts: extract method delete()
* lint
2024-06-06 10:21:03 +02:00
mmetc
9e859c0c8c
refactor pkg/database, pkg/models ( #3022 )
...
* pkg/models: Source.String()
* pkg/models: Alert.FormatAsStrings()
* cscli alerts list: sort remediation keys
avoid printing
"ban: ... captcha: ..."
in one line, and
"captcha: ... ban: ..."
in another
* remove unused methods; drop else branch
* lint
2024-06-05 12:01:13 +02:00
mmetc
73e03ef556
lint: enable revive/if-return, revive/error-strings ( #3057 )
...
* lint: enable revive/if-return, revive/error-strings
* lint
2024-06-05 11:37:57 +02:00
mmetc
3dd17b9081
tests: log.Fatal -> return err ( #3056 )
...
* tests: log.Fatal -> return err
* lint
2024-06-05 11:04:54 +02:00
Manuel Sabban
2865b69855
fix tests in 01_crowdsec.bats for packages testing ( #3054 )
2024-06-05 08:26:32 +02:00
Manuel Sabban
f0f27ee5cb
add decently new version of python for centos 7 and 8 for testing ( #3053 )
...
* add decently new version of python for centos 7 and 8
* update ansible requirements
2024-06-04 22:39:13 +02:00
mmetc
d614ecbdcf
CI/bats: test remediation api via socket ( #3052 )
2024-06-04 15:09:19 +02:00
mmetc
9101de95d8
pkg/database: refactor & rename "soft delete" to "expire" ( #3025 )
...
* pkg/database: replace parameter with explicit methods
* merge methods with recusion
* rename "soft delete" -> "expire"
* lint
2024-06-04 13:19:46 +02:00
mmetc
fba4237fbd
lint: revive/useless-break ( #3050 )
2024-06-04 09:48:21 +02:00
mmetc
7313d49145
enable linter: revive(bool-literal-in-expr) ( #2983 )
2024-06-04 09:47:25 +02:00
mmetc
9823ed61b6
cscli: log.Fatal -> return err ( #3049 )
...
* cscli: log.Fatal -> return err
* lint
2024-06-03 12:21:00 +02:00
mmetc
c1e858cbca
cscli: refactor alerts/console/decisions/setup ( #3003 )
...
* cscli alerts: extract list(), inspect()
* cscli console: extract enroll()
* cscli decisions: extract list()
* support dump: don't use global
* cscli setup: split command constructors
* lint
2024-05-31 19:15:05 +02:00
mmetc
89d02e9458
CI/lint: enable some "revive" rules ( #3041 )
...
argument-limit
Warns when a function receives more parameters than the maximum set by the rule's configuration.
bare-return
Warns on bare (a.k.a. naked) returns
context-as-argument
By convention, context.Context should be the first parameter of a function.
duplicated-imports
It is possible to unintentionally import the same package twice.
modifies-parameter
A function that modifies its parameters can be hard to understand. It can also be misleading if the arguments are passed by value by the caller.
redundant-import-alias
This rule warns on redundant import aliases.
unreachable-code
This rule spots and proposes to remove unreachable code.
2024-05-31 16:45:47 +02:00
mmetc
8501f459c3
db,lapi: round durations and timestamps to 1 second ( #3015 )
...
* cscli/lapi: round decision duration to 1 second
* db: round created, updated... timestamps to 1 second
2024-05-31 16:24:33 +02:00
mmetc
599a5a49a1
pkg/dumps.DumpTree: split to reduce complexity ( #3001 )
...
* pkg/dumps.DumpTree: split to reduce complexity
* lint
2024-05-31 16:08:06 +02:00
Manuel Sabban
95bc5880f4
update vagrant image for fc39, fc40 and ubuntu24.04 ( #3042 )
...
* update test distribution
* add skip file to avoid mysql tests
* add ubuntu 24.04
2024-05-31 15:56:13 +02:00
mmetc
b8ee31ade2
pkg/database: simplify flush agents/bouncers ( #3026 )
...
* pkg/database: simplify flush agents/bouncers
* lint
2024-05-31 15:44:30 +02:00
mmetc
6dbc5fd522
db: mark immutable columns / remove unused ( #3024 )
...
* db: mark immutable columns
* db: drop unused column
* lint
2024-05-31 15:19:48 +02:00
mmetc
02e2c8aed7
deps: use ent 0.13.1 ( #3023 )
2024-05-31 15:00:38 +02:00
blotus
16bfab86c8
check type assertion in geoip enrichers ( #3040 )
2024-05-31 09:38:43 +02:00
