mirrors/docker-etchosts
1
0
Fork 0
mirror of https://github.com/costela/docker-etchosts.git synced 2025-05-10 17:35:41 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fsync tmpfile file before overwriting hostsfile

Browse source
This commit is contained in:
Leo Antunes 2018-08-25 12:29:49 +02:00
parent 42552f4316
commit cc75212b46
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
etchosts.go
View file

@ -101,14 +101,20 @@ func writeEntryWithBanner(tmp io.Writer, ip string, names []string) error {
}
func movePreservePerms(src, dst *os.File) error {
if err := src.Sync(); err != nil {
return fmt.Errorf("could not sync changes to %s: %s", src.Name(), err)
}
etcHostsInfo, err := dst.Stat()
if err != nil {
return fmt.Errorf("could not stat %s: %s", dst.Name(), err)
}
// We try moving first because it's atomic; the fallback strategy is copying the content, which might generate a
// broken hosts file if some other process writes to it at the same time.
err = os.Rename(src.Name(), dst.Name())
if err != nil {
log.Infof("could not rename to %s; falling back to less safe direct-write (%s)", config.EtcHostsPath, err)
log.Infof("could not rename to %s; falling back to less safe direct-write (%s)", dst.Name(), err)
if _, err := src.Seek(0, io.SeekStart); err != nil {
return err