mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-13 03:15:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix: test_noreply_pipeline flakiness (#4102)

Browse source 
Fixes #3896. Now we retry several times.
In my checks this should significantly reduce the failure probability.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
This commit is contained in:
Roman Gershman 2024-11-10 13:39:24 +02:00 • committed by GitHub
parent ab86d358b0
commit 1eef773d0a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 17 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

33
tests/dragonfly/pymemcached_test.py
View file

@ -57,28 +57,29 @@ async def test_noreply_pipeline(df_server: DflyInstance, memcached_client: MCCli
so all the commands are pipelined. Assert pipelines work correctly and the so all the commands are pipelined. Assert pipelines work correctly and the
succeeding regular command receives a reply (it should join the pipeline as last). succeeding regular command receives a reply (it should join the pipeline as last).
""" """
keys = [f"k{i}" for i in range(2000)]
values = [f"d{i}" for i in range(len(keys))]
for k, v in zip(keys, values):
memcached_client.set(k, v, noreply=True)
# quick follow up before the pipeline finishes
assert memcached_client.get("k10") == b"d10"
# check all commands were executed
assert memcached_client.get_many(keys) == {k: v.encode() for k, v in zip(keys, values)}
client = df_server.client() client = df_server.client()
info = await client.info() for attempts in range(2):
if info["total_pipelined_commands"] == 0: keys = [f"k{i}" for i in range(1000)]
logging.error("No pipelined commands were detected. Info: \n" + str(info)) values = [f"d{i}" for i in range(len(keys))]
# Try again
for k, v in zip(keys, values): for k, v in zip(keys, values):
memcached_client.set(k, v, noreply=True) memcached_client.set(k, v, noreply=True)
# quick follow up before the pipeline finishes
assert memcached_client.get("k10") == b"d10"
# check all commands were executed
assert memcached_client.get_many(keys) == {k: v.encode() for k, v in zip(keys, values)}
info = await client.info() info = await client.info()
logging.error("Second Info: \n" + str(info)) if info["total_pipelined_commands"] > 100:
assert False return
logging.warning(
f"Have not identified pipelining at attempt {attempts} Info: \n" + str(info)
)
await client.flushall()
assert False, "Pipelining not detected"
@dfly_args(DEFAULT_ARGS) @dfly_args(DEFAULT_ARGS)