mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 18:35:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(rdb): Remove transaction from pre/post load search index rebuild (#2419)

Browse source
This commit is contained in:
Vladislav 2024-01-16 10:08:16 +03:00 • committed by GitHub
parent de817098a7
commit 1fb3c74933
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/server/rdb_load.cc
View file

@ -2495,10 +2495,9 @@ void RdbLoader::PerformPreLoad(Service* service) {
if (cmd == nullptr)
return; // MacOS
Transaction::RunOnceAsCommand(cmd, [](auto* trans, auto* es) {
shard_set->AwaitRunningOnShardQueue([](EngineShard* es) {
for (const auto& name : es->search_indices()->GetIndexNames())
es->search_indices()->DropIndex(name);
return OpStatus::OK;
});
}
@ -2508,9 +2507,8 @@ void RdbLoader::PerformPostLoad(Service* service) {
return;
// Rebuild all search indices as only their definitions are extracted from the snapshot
Transaction::RunOnceAsCommand(cmd, [](auto* trans, auto* es) {
es->search_indices()->RebuildAllIndices(trans->GetOpArgs(es));
return OpStatus::OK;
shard_set->AwaitRunningOnShardQueue([](EngineShard* es) {
es->search_indices()->RebuildAllIndices(OpArgs{es, nullptr, DbContext{0, GetCurrentTimeMs()}});
});
}