mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 18:35:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(metrics): add corresponding comments to command metrics (#4674)

Browse source 
---------

Signed-off-by: Lewis <lewis@ourzora.com>
This commit is contained in:
Lewis 2025-03-04 08:30:55 +00:00 • committed by Roman Gershman
parent 4f9103073b
commit 21b19e9abb
No known key found for this signature in database
GPG key ID: F25B77EAF8AEBA7A
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/server/server_family.cc
View file

@ -1447,15 +1447,21 @@ void PrintPrometheusMetrics(uint64_t uptime, const Metrics& m, DflyCmd* dfly_cmd
if (!m.cmd_stats_map.empty()) {
string command_metrics;
AppendMetricHeader("commands", "Metrics for all commands ran", MetricType::COUNTER,
AppendMetricHeader("commands_total", "Total number of commands executed", MetricType::COUNTER,
&command_metrics);
for (const auto& [name, stat] : m.cmd_stats_map) {
const auto calls = stat.first;
const double duration_seconds = stat.second * 1e-6;
AppendMetricValue("commands_total", calls, {"cmd"}, {name}, &command_metrics);
}
AppendMetricHeader("commands_duration_seconds", "Duration of commands in seconds",
MetricType::HISTOGRAM, &command_metrics);
for (const auto& [name, stat] : m.cmd_stats_map) {
const double duration_seconds = stat.second * 1e-6;
AppendMetricValue("commands_duration_seconds", duration_seconds, {"cmd"}, {name},
&command_metrics);
}
absl::StrAppend(&resp->body(), command_metrics);
}