mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 18:35:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

feat: Use const ConnectionContext in VerifyCommand (#1633)

Browse source 
* feat: Use const ConnectionContext in VerifyCommand

Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
This commit is contained in:
Vladislav 2023-08-06 11:02:43 +03:00 • committed by GitHub
parent 6faa530d42
commit 3bc1e26050
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 148 additions and 119 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/server/main_service.h
View file

@ -24,7 +24,6 @@ using facade::MemcacheParser;
class Service : public facade::ServiceInterface {
public:
using error_code = std::error_code;
struct InitOpts {
bool disable_time_update;
@ -120,12 +119,16 @@ class Service : public facade::ServiceInterface {
CmdArgList keys, args;
};
// Return false if command is invalid and reply with error.
bool VerifyCommand(const CommandId* cid, CmdArgList args, ConnectionContext* cntx);
// Verify command exists and has no obvious formatting errors
std::optional<facade::ErrorReply> VerifyCommandArguments(const CommandId* cid, CmdArgList args);
// Return false if not all keys are owned by the server when running in cluster mode.
// If false is returned error was sent to the client.
bool CheckKeysOwnership(const CommandId* cid, CmdArgList args, ConnectionContext* dfly_cntx);
// Verify command can be executed
std::optional<facade::ErrorReply> VerifyCommand(const CommandId* cid, CmdArgList args,
const ConnectionContext& cntx);
// Return error if not all keys are owned by the server when running in cluster mode
std::optional<facade::ErrorReply> CheckKeysOwnership(const CommandId* cid, CmdArgList args,
const ConnectionContext& dfly_cntx);
const CommandId* FindCmd(CmdArgList args) const;
@ -141,6 +144,7 @@ class Service : public facade::ServiceInterface {
base::VarzValue::Map GetVarzStats();
private:
util::ProactorPool& pp_;
ServerFamily server_family_;