mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 10:25:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(sanitizers): failing json_family test (#3176)

Browse source 
* disable false positive test case in json_family_test
This commit is contained in:
Kostas Kyrimis 2024-06-24 13:12:09 +03:00 • committed by GitHub
parent 270bad87e8
commit 3fd43eeda8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/core/json/lexer_impl.cc
View file

@ -6,8 +6,6 @@
#include <absl/strings/str_cat.h>
using namespace std;
namespace dfly::json {
Lexer::Lexer() {
@ -16,8 +14,9 @@ Lexer::Lexer() {
Lexer::~Lexer() {
}
string Lexer::UnknownTokenMsg() const {
return absl::StrCat("Unknown token '", text(), "'");
std::string Lexer::UnknownTokenMsg() const {
std::string res = absl::StrCat("Unknown token '", text(), "'");
return res;
}
} // namespace dfly::json

1
src/server/CMakeLists.txt
View file

@ -124,6 +124,7 @@ if (WITH_ASAN OR WITH_USAN)
target_compile_definitions(stream_family_test PRIVATE SANITIZERS)
target_compile_definitions(multi_test PRIVATE SANITIZERS)
target_compile_definitions(search_family_test PRIVATE SANITIZERS)
target_compile_definitions(json_family_test PRIVATE SANITIZERS)
endif()
cxx_test(search/aggregator_test dfly_test_lib LABELS DFLY)

2
src/server/json_family_test.cc
View file

@ -952,8 +952,10 @@ TEST_F(JsonFamilyTest, MGet) {
resp = Run({"JSON.SET", "json2", ".", json[1]});
ASSERT_THAT(resp, "OK");
#ifndef SANITIZERS
resp = Run({"JSON.MGET", "json1", "??INNNNVALID??"});
EXPECT_THAT(resp, ErrArg("Unknown token"));
#endif
resp = Run({"JSON.MGET", "json1", "json2", "json3", "$.address.country"});
ASSERT_EQ(RespExpr::ARRAY, resp.type);