chore: get rid of MutableSlice (#3952)

* chore: get rid of MutableSlice

Signed-off-by: Roman Gershman <roman@dragonflydb.io>

* chore: comments

---------

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
This commit is contained in:
Roman Gershman 2024-10-23 21:50:39 +03:00 committed by GitHub
parent 0ebc1a11e1
commit 4aa0ca1ef7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
33 changed files with 95 additions and 147 deletions

View file

@ -37,10 +37,10 @@ class Service : public facade::ServiceInterface {
void Shutdown();
// Prepare command execution, verify and execute, reply to context
void DispatchCommand(CmdArgList args, facade::ConnectionContext* cntx) final;
void DispatchCommand(ArgSlice args, facade::ConnectionContext* cntx) final;
// Execute multiple consecutive commands, possibly in parallel by squashing
size_t DispatchManyCommands(absl::Span<CmdArgList> args_list,
size_t DispatchManyCommands(absl::Span<ArgSlice> args_list,
facade::ConnectionContext* cntx) final;
// Check VerifyCommandExecution and invoke command with args
@ -55,7 +55,7 @@ class Service : public facade::ServiceInterface {
// Verify command prepares excution in correct state.
// It's usually called before command execution. Only for multi/exec transactions it's checked
// when the command is queued for execution, not before the execution itself.
std::optional<facade::ErrorReply> VerifyCommandState(const CommandId* cid, CmdArgList tail_args,
std::optional<facade::ErrorReply> VerifyCommandState(const CommandId* cid, ArgSlice tail_args,
const ConnectionContext& cntx);
void DispatchMC(const MemcacheParser::Command& cmd, std::string_view value,