mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 10:25:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

feat: allow cluster READONLY command (#4727)

Browse source 
* feat: allow cluster READONLY command
This commit is contained in:
Borys 2025-03-09 09:27:33 +02:00 • committed by GitHub
parent d8500c9686
commit 57aa91fdb6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 41 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/server/cluster/cluster_family.cc
View file

@ -442,9 +442,6 @@ void ClusterFamily::Cluster(CmdArgList args, const CommandContext& cmd_cntx) {
}
void ClusterFamily::ReadOnly(CmdArgList args, const CommandContext& cmd_cntx) {
if (!IsClusterEmulated()) {
return cmd_cntx.rb->SendError(kClusterDisabled);
}
cmd_cntx.rb->SendOk();
}

41
tests/dragonfly/cluster_test.py
View file

@ -3118,3 +3118,44 @@ async def test_cluster_sharded_pub_sub_migration(df_factory: DflyInstanceFactory
assert message == {"type": "subscribe", "pattern": None, "channel": b"kostas", "data": 1}
message = consumer.get_sharded_message(target_node=node_a)
assert message == {"type": "unsubscribe", "pattern": None, "channel": b"kostas", "data": 0}
@dfly_args({"proactor_threads": 4, "cluster_mode": "yes"})
async def test_readonly_replication(
df_factory: DflyInstanceFactory, df_seeder_factory: DflySeederFactory
):
# create cluster master and replica
# For now replica always should work in read-only mode
# READONLY command returns always OK without any impact
# In the future we may decide to implement the same behavior as REDIS
instances = [
df_factory.create(port=next(next_port), admin_port=next(next_port)) for i in range(2)
]
df_factory.start_all(instances)
nodes = [await create_node_info(n) for n in instances]
m1_node, r1_node = nodes
master_nodes = [m1_node]
m1_node.slots = [(0, 16383)]
m1_node.replicas = [r1_node]
logging.debug("Push initial config")
await push_config(
json.dumps(generate_config(master_nodes)), [node.admin_client for node in nodes]
)
logging.debug("create data")
await m1_node.client.execute_command("SET X 1")
logging.debug("start replication")
await r1_node.admin_client.execute_command(f"replicaof localhost {m1_node.instance.port}")
await wait_available_async(r1_node.admin_client)
assert await r1_node.client.execute_command("GET X") == "1"
assert await r1_node.client.execute_command("READONLY")
assert await r1_node.client.execute_command("GET X") == "1"
# This behavior can be changed in the future
assert await r1_node.client.execute_command("GET Y") == None