mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-10 18:05:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(reply_builder): remove virtual modifier in SendError(ErrorReply) method (#3191)

Browse source 
fixes dragonflydb#3190

Signed-off-by: Stepan Bagritsevich <bagr.stepan@gmail.com>
This commit is contained in:
Stepan Bagritsevich 2024-06-19 18:50:22 +04:00 • committed by GitHub
parent 50f3ffbe52
commit 5f4fb57df4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 2 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/facade/reply_builder.h
View file

@ -79,8 +79,8 @@ class SinkReplyBuilder {
}
virtual void SendError(std::string_view str, std::string_view type = {}) = 0; // MC and Redis
virtual void SendError(ErrorReply error);
virtual void SendError(OpStatus status);
void SendError(ErrorReply error);
virtual void SendStored() = 0; // Reply for set commands.
virtual void SendSetSkipped() = 0;

5
src/facade/reply_capture.cc
View file

@ -21,11 +21,6 @@ void CapturingReplyBuilder::SendError(std::string_view str, std::string_view typ
Capture(Error{str, type});
}
void CapturingReplyBuilder::SendError(ErrorReply error) {
SKIP_LESS(ReplyMode::ONLY_ERR);
Capture(Error{error.ToSv(), error.kind});
}
void CapturingReplyBuilder::SendMGetResponse(MGetResponse resp) {
SKIP_LESS(ReplyMode::FULL);
Capture(std::move(resp));

2
src/facade/reply_capture.h
View file

@ -24,12 +24,12 @@ class CapturingReplyBuilder : public RedisReplyBuilder {
public:
void SendError(std::string_view str, std::string_view type = {}) override;
void SendError(ErrorReply error) override;
void SendMGetResponse(MGetResponse resp) override;
// SendStored -> SendSimpleString("OK")
// SendSetSkipped -> SendNull()
void SendError(OpStatus status) override;
using RedisReplyBuilder::SendError;
void SendNullArray() override;
void SendEmptyArray() override;