mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 10:25:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix: removal of Expiry bit when overriding external strings (#4785)

Browse source 
The bug: during the override of the existing external string, we called
`TieredStorage::Delete` to delete the external reference. This function
called CompactObj::Reset that cleared all the attributes on the value, including
expiry.

The fix: preserve the mask but clear the external state from the object.
Fixes #4672

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
This commit is contained in:
Roman Gershman 2025-03-17 13:45:07 +02:00 • committed by GitHub
parent 151e40e2c0
commit 66c2973a99
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 42 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/compact_object.cc
View file

@ -875,6 +875,8 @@ void CompactObj::InitRobj(CompactObjType type, unsigned encoding, void* obj) {
}
void CompactObj::SetInt(int64_t val) {
DCHECK(!IsExternal());
if (INT_TAG != taglen_) {
SetMeta(INT_TAG, mask_ & ~kEncMask);
}