mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 18:35:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

chore: reset enable_direct_fd to avoid socket leakage in kernel (#3051)

Browse source 
The leakage can be identified by checking /proc/net/sockstat
Fixes #3045

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
This commit is contained in:
Roman Gershman 2024-05-16 09:44:53 +03:00 • committed by GitHub
parent 6b8a8b6410
commit 73e44a941e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/server/dfly_main.cc
View file

@ -79,6 +79,10 @@ ABSL_FLAG(bool, version_check, true,
ABSL_FLAG(uint16_t, tcp_backlog, 128, "TCP listen(2) backlog parameter.");
#ifdef __linux__
ABSL_DECLARE_FLAG(bool, enable_direct_fd);
#endif
using namespace util;
using namespace facade;
using namespace io;
@ -716,6 +720,10 @@ Usage: dragonfly [FLAGS]
unique_ptr<util::ProactorPool> pool;
#ifdef __linux__
// NOTE: Seems that enable_direct_fd causes sockets leakage.
// Until it is fixed in helio, we disable it.
absl::SetFlag(&FLAGS_enable_direct_fd, false);
base::sys::KernelVersion kver;
base::sys::GetKernelVersion(&kver);