mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-12 19:05:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

feat server: bring visibility to script errors (#2879)

Browse source 
* feat server: bring visibility to script errorד

Signed-off-by: adi_holden <adi@dragonflydb.io>
This commit is contained in:
adiholden 2024-04-11 11:25:41 +03:00 • committed by GitHub
parent 48d7fa7eba
commit 7580a88ca5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 56 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/server/script_mgr.cc
View file

@ -33,8 +33,12 @@ ABSL_FLAG(
bool, lua_auto_async, false,
"If enabled, call/pcall with discarded values are automatically replaced with acall/apcall.");
namespace dfly {
ABSL_FLAG(bool, lua_allow_undeclared_auto_correct, false,
"If enabled, when a script that is not allowed to run with undeclared keys is trying to "
"access undeclared keys, automaticaly set the script flag to be able to run with "
"undeclared key.");
namespace dfly {
using namespace std;
using namespace facade;
using namespace util;
@ -283,6 +287,29 @@ optional<ScriptMgr::ScriptData> ScriptMgr::Find(std::string_view sha) const {
return std::nullopt;
}
void ScriptMgr::OnScriptError(std::string_view sha, std::string_view error) {
++tl_facade_stats->reply_stats.script_error_count;
lock_guard lk{mu_};
auto it = db_.find(sha);
if (it == db_.end()) {
return;
}
if (++it->second.error_resp < 5) {
LOG(ERROR) << "Error running script (call to " << sha << "): " << error;
}
// If script has undeclared_keys and was not flaged to run in this mode we will change the
// script flag - this will make script next run to not fail but run as global.
if (absl::GetFlag(FLAGS_lua_allow_undeclared_auto_correct)) {
size_t pos = error.rfind(kUndeclaredKeyErr);
if (pos != string::npos) {
it->second.undeclared_keys = true;
LOG(WARNING) << "Setting undeclared_keys flag for script with sha : (" << sha << ")";
UpdateScriptCaches(sha, it->second);
}
}
}
void ScriptMgr::FlushAllScript() {
lock_guard lk{mu_};
db_.clear();