From 76edd0d027abfa803598738ca99d3eb6d6553890 Mon Sep 17 00:00:00 2001 From: Shahar Mike Date: Tue, 23 Jul 2024 11:17:23 +0300 Subject: [PATCH] fix(server): Require >=1 args to `GETEX` (#3366) Without this change, issuing `redis-cli getex` crashes Dragonfly --- src/server/string_family.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/string_family.cc b/src/server/string_family.cc index 1dd73d48f..b34d54a5c 100644 --- a/src/server/string_family.cc +++ b/src/server/string_family.cc @@ -1454,7 +1454,7 @@ void StringFamily::Register(CommandRegistry* registry) { << CI{"DECRBY", CO::WRITE | CO::FAST, 3, 1, 1, acl::kDecrBy}.HFUNC(DecrBy) << CI{"GET", CO::READONLY | CO::FAST, 2, 1, 1, acl::kGet}.HFUNC(Get) << CI{"GETDEL", CO::WRITE | CO::FAST, 2, 1, 1, acl::kGetDel}.HFUNC(GetDel) - << CI{"GETEX", CO::WRITE | CO::DENYOOM | CO::FAST | CO::NO_AUTOJOURNAL, -1, 1, 1, acl::kGetEx} + << CI{"GETEX", CO::WRITE | CO::DENYOOM | CO::FAST | CO::NO_AUTOJOURNAL, -2, 1, 1, acl::kGetEx} .HFUNC(GetEx) << CI{"GETSET", CO::WRITE | CO::DENYOOM | CO::FAST, 3, 1, 1, acl::kGetSet}.HFUNC(GetSet) << CI{"MGET", CO::READONLY | CO::FAST | CO::IDEMPOTENT, -2, 1, -1, acl::kMGet}.HFUNC(MGet)