mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-10 18:05:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix: test_replica_snapshot_with_big_values_while_seeding (#4902)

Browse source 
* throttle the test to require less memory
* increase reg test timeout on the ci from 50 to 60 mins

Signed-off-by: kostas <kostas@dragonflydb.io>
This commit is contained in:
Kostas Kyrimis 2025-04-09 11:20:58 +03:00 • committed by GitHub
parent c129834cbf
commit 7adb071f2a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.github/actions/regression-tests/action.yml vendored
View file

@ -54,11 +54,11 @@ runs:
if [[ "${{inputs.epoll}}" == 'epoll' ]]; then if [[ "${{inputs.epoll}}" == 'epoll' ]]; then
export FILTER="${{inputs.filter}} and not exclude_epoll" export FILTER="${{inputs.filter}} and not exclude_epoll"
# Run only replication tests with epoll # Run only replication tests with epoll
timeout 50m pytest -m "$FILTER" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --df force_epoll=true --log-cli-level=INFO || code=$? timeout 60m pytest -m "$FILTER" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --df force_epoll=true --log-cli-level=INFO || code=$?
else else
export FILTER="${{inputs.filter}}" export FILTER="${{inputs.filter}}"
# Run only replication tests with epoll # Run only replication tests with epoll
timeout 50m pytest -m "$FILTER" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --log-cli-level=INFO || code=$? timeout 60m pytest -m "$FILTER" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --log-cli-level=INFO || code=$?
fi fi
# timeout returns 124 if we exceeded the timeout duration # timeout returns 124 if we exceeded the timeout duration

5
tests/dragonfly/replication_test.py
View file

@ -2977,7 +2977,7 @@ async def test_bug_in_json_memory_tracking(df_factory: DflyInstanceFactory):
rand = random.randint(1, 4) rand = random.randint(1, 4)
await c_master.execute_command(f"EXPIRE tmp:{i} {rand} NX") await c_master.execute_command(f"EXPIRE tmp:{i} {rand} NX")
seeder = SeederV2(key_target=100_000) seeder = SeederV2(key_target=50_000)
fill_task = asyncio.create_task(seeder.run(master.client())) fill_task = asyncio.create_task(seeder.run(master.client()))
for replica in c_replicas: for replica in c_replicas:
@ -2989,7 +2989,6 @@ async def test_bug_in_json_memory_tracking(df_factory: DflyInstanceFactory):
await fill_task await fill_task
@pytest.mark.skip("Skipped temporarily while being investigated")
async def test_replica_snapshot_with_big_values_while_seeding(df_factory: DflyInstanceFactory): async def test_replica_snapshot_with_big_values_while_seeding(df_factory: DflyInstanceFactory):
proactors = 4 proactors = 4
master = df_factory.create(proactor_threads=proactors, dbfilename="") master = df_factory.create(proactor_threads=proactors, dbfilename="")
@ -2999,7 +2998,7 @@ async def test_replica_snapshot_with_big_values_while_seeding(df_factory: DflyIn
c_replica = replica.client() c_replica = replica.client()
# 50% big values # 50% big values
seeder_config = dict(key_target=20_000, huge_value_target=10000) seeder_config = dict(key_target=8_000, huge_value_target=4_000)
# Fill instance with test data # Fill instance with test data
seeder = SeederV2(**seeder_config) seeder = SeederV2(**seeder_config)
await seeder.run(c_master, target_deviation=0.01) await seeder.run(c_master, target_deviation=0.01)