mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 10:25:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix: JSON.ARRPOP command crash fixed (#5026)

Browse source 
fixed: https://github.com/dragonflydb/dragonfly/issues/5025
This commit is contained in:
Volodymyr Yavdoshenko 2025-04-30 08:00:01 +03:00 • committed by GitHub
parent 13d8062bb9
commit 84456a2442
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/server/json_family.cc
View file

@ -1794,6 +1794,10 @@ void JsonFamily::ArrPop(CmdArgList args, const CommandContext& cmd_cntx) {
int index = parser.NextOrDefault<int>(-1); int index = parser.NextOrDefault<int>(-1);
auto* builder = static_cast<RedisReplyBuilder*>(cmd_cntx.rb); auto* builder = static_cast<RedisReplyBuilder*>(cmd_cntx.rb);
if (auto err = parser.Error(); err) {
return builder->SendError(err->MakeReply());
}
WrappedJsonPath json_path = GET_OR_SEND_UNEXPECTED(ParseJsonPath(path)); WrappedJsonPath json_path = GET_OR_SEND_UNEXPECTED(ParseJsonPath(path));
auto cb = [&](Transaction* t, EngineShard* shard) { auto cb = [&](Transaction* t, EngineShard* shard) {

5
src/server/json_family_test.cc
View file

@ -3074,4 +3074,9 @@ TEST_F(JsonFamilyTest, SetNestedFields) {
EXPECT_EQ(resp, R"({"-field2":2,"field1":1})"); EXPECT_EQ(resp, R"({"-field2":2,"field1":1})");
} }
TEST_F(JsonFamilyTest, ArrPopWithFormatParameter) {
auto resp = Run({"JSON.ARRPOP", "test_resp3", "FORMAT", "EXPAND", "$.a"});
ASSERT_THAT(resp, ErrArg("value is not an integer or out of range"));
}
} // namespace dfly } // namespace dfly