mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 10:25:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

chore: fix test_snapshot (#4607)

Browse source
This commit is contained in:
Kostas Kyrimis 2025-02-13 17:29:41 +02:00 • committed by adi_holden
parent f3ce3ce0c8
commit 979506ca7d
1 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/dragonfly/snapshot_test.py
View file

@ -154,7 +154,7 @@ async def test_dbfilenames(
{ {
**BASIC_ARGS, **BASIC_ARGS,
"proactor_threads": 4, "proactor_threads": 4,
"dbfilename": "test-redis-load-rdb", "dbfilename": "test-redis-load-rdb",
} }
) )
async def test_redis_load_snapshot( async def test_redis_load_snapshot(
@ -402,13 +402,13 @@ class TestDflySnapshotOnShutdown:
assert memory_counters == {"object_used_memory": 0} assert memory_counters == {"object_used_memory": 0}
@pytest.mark.asyncio @pytest.mark.asyncio
@pytest.mark.slow
async def test_snapshot(self, df_server, async_client): async def test_snapshot(self, df_server, async_client):
"""Checks that: """Checks that:
1. After reloading the snapshot file the data is the same 1. After reloading the snapshot file the data is the same
2. Memory counters after loading from snapshot is similar to before creating a snapshot 2. Memory counters after loading should be non zero
3. Memory counters after deleting all keys loaded by snapshot - this validates the memory 3. Memory counters after deleting all keys loaded by snapshot - this validates the memory
counting when loading from snapshot.""" counting when loading from snapshot."""
seeder = StaticSeeder(**self.SEEDER_ARGS) seeder = StaticSeeder(**self.SEEDER_ARGS)
await seeder.run(async_client) await seeder.run(async_client)
start_capture = await StaticSeeder.capture(async_client) start_capture = await StaticSeeder.capture(async_client)
@ -426,10 +426,8 @@ class TestDflySnapshotOnShutdown:
memory_after = await self._get_info_memory_fields(async_client) memory_after = await self._get_info_memory_fields(async_client)
for counter, value in memory_before.items(): for counter, value in memory_before.items():
# Unfortunately memory usage sometimes depends on order of insertion / deletion, so # Counters should be non zero.
# it's usually not exactly the same. For the test to be stable we check that it's assert memory_after[counter] > 0
# at least 50% that of the original value.
assert memory_after[counter] >= 0.5 * value
await self._delete_all_keys(async_client) await self._delete_all_keys(async_client)
memory_empty = await self._get_info_memory_fields(async_client) memory_empty = await self._get_info_memory_fields(async_client)