mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 02:15:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

feat(server): Implement brpoplpush for single shard case.

Browse source 
A simple case where both src and dest keys are located in the same shard.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
This commit is contained in:
Roman Gershman 2023-01-07 17:06:59 +02:00 • committed by Roman Gershman
parent fe2a491824
commit 9ca636e49d
9 changed files with 223 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/server/blocking_controller.cc
View file

@ -136,7 +136,7 @@ void BlockingController::RunStep(Transaction* completed_t) {
awakened_indices_.clear();
}
void BlockingController::AddWatched(Transaction* trans) {
void BlockingController::AddWatched(ArgSlice keys, Transaction* trans) {
VLOG(1) << "AddWatched [" << owner_->shard_id() << "] " << trans->DebugId();
auto [dbit, added] = watched_dbs_.emplace(trans->db_index(), nullptr);
@ -146,8 +146,7 @@ void BlockingController::AddWatched(Transaction* trans) {
DbWatchTable& wt = *dbit->second;
auto args = trans->ShardArgsInShard(owner_->shard_id());
for (auto key : args) {
for (auto key : keys) {
auto [res, inserted] = wt.queue_map.emplace(key, nullptr);
if (inserted) {
res->second.reset(new WatchQueue);
@ -167,7 +166,7 @@ void BlockingController::AddWatched(Transaction* trans) {
}
// Runs in O(N) complexity in the worst case.
void BlockingController::RemoveWatched(Transaction* trans) {
void BlockingController::RemoveWatched(ArgSlice keys, Transaction* trans) {
VLOG(1) << "RemoveWatched [" << owner_->shard_id() << "] " << trans->DebugId();
auto dbit = watched_dbs_.find(trans->db_index());
@ -175,11 +174,13 @@ void BlockingController::RemoveWatched(Transaction* trans) {
return;
DbWatchTable& wt = *dbit->second;
auto args = trans->ShardArgsInShard(owner_->shard_id());
for (auto key : args) {
for (auto key : keys) {
auto watch_it = wt.queue_map.find(key);
// that can happen in case of duplicate keys or when we do not watch on all the argument keys
// like with BLPOPRPUSH.
if (watch_it == wt.queue_map.end())
continue; // that can happen in case of duplicate keys
continue;
WatchQueue& wq = *watch_it->second;
for (auto items_it = wq.items.begin(); items_it != wq.items.end(); ++items_it) {