chore: remove unneeded check-fails (#3054)

This commit is contained in:
Roman Gershman 2024-05-16 18:45:26 +03:00 committed by GitHub
parent d73ffc27b9
commit 9d623d0f4b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -1783,15 +1783,16 @@ optional<ScriptMgr::ScriptParams> LoadScript(string_view sha, ScriptMgr* script_
return std::nullopt;
string err;
CHECK_EQ(Interpreter::ADD_OK, interpreter->AddFunction(sha, script_data->body, &err));
CHECK(err.empty()) << err;
Interpreter::AddResult add_res = interpreter->AddFunction(sha, script_data->body, &err);
if (add_res != Interpreter::ADD_OK) {
LOG(ERROR) << "Error adding " << sha << " to database, err " << err;
return std::nullopt;
}
return script_data;
}
auto params = ss->GetScriptParams(sha);
CHECK(params); // We update all caches from script manager
return params;
return ss->GetScriptParams(sha);
}
// Determine multi mode based on script params.