mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 10:25:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

chore: expose SBF via compact_object (#2797)

Browse source 
* chore: expose SBF via compact_object
---------

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
This commit is contained in:
Roman Gershman 2024-03-30 22:35:22 +03:00 • committed by GitHub
parent 6d87acfc43
commit 9e23f85e6b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 114 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/core/compact_object.cc
View file

@ -25,6 +25,7 @@ extern "C" {
#include "base/flags.h"
#include "base/logging.h"
#include "base/pod_array.h"
#include "core/bloom.h"
#include "core/detail/bitpacking.h"
#include "core/sorted_map.h"
#include "core/string_map.h"
@ -631,6 +632,10 @@ unsigned CompactObj::ObjType() const {
return OBJ_JSON;
}
if (taglen_ == SBF_TAG) {
return OBJ_SBF;
}
LOG(FATAL) << "TBD " << int(taglen_);
return 0;
}
@ -649,6 +654,7 @@ string_view CompactObj::ObjTypeToString(unsigned type) {
OBJECT_TYPE_CASE(OBJ_MODULE);
OBJECT_TYPE_CASE(OBJ_STREAM);
OBJECT_TYPE_CASE(OBJ_JSON);
OBJECT_TYPE_CASE(OBJ_SBF);
default:
DCHECK(false) << "Unknown object type " << type;
return "OTHER";
@ -707,6 +713,16 @@ void CompactObj::SetJson(JsonType&& j) {
}
}
void CompactObj::SetSBF(uint64_t initial_capacity, double fp_prob, double grow_factor) {
if (taglen_ == SBF_TAG) { // already json
*u_.sbf = SBF(initial_capacity, fp_prob, grow_factor, tl.local_mr);
} else {
SetMeta(SBF_TAG);
void* ptr = tl.local_mr->allocate(sizeof(SBF), alignof(SBF));
u_.sbf = new (ptr) SBF(initial_capacity, fp_prob, grow_factor, tl.local_mr);
}
}
void CompactObj::SetString(std::string_view str) {
uint8_t mask = mask_ & ~kEncMask;
CHECK(!IsExternal());
@ -876,7 +892,7 @@ bool CompactObj::HasAllocated() const {
(taglen_ == ROBJ_TAG && u_.r_obj.inner_obj() == nullptr))
return false;
DCHECK(taglen_ == ROBJ_TAG || taglen_ == SMALL_TAG || taglen_ == JSON_TAG);
DCHECK(taglen_ == ROBJ_TAG || taglen_ == SMALL_TAG || taglen_ == JSON_TAG || taglen_ == SBF_TAG);
return true;
}
@ -991,6 +1007,8 @@ void CompactObj::Free() {
VLOG(1) << "Freeing JSON object";
u_.json_obj.json_ptr->~JsonType();
tl.local_mr->deallocate(u_.json_obj.json_ptr, sizeof(JsonType), kAlignSize);
} else if (taglen_ == SBF_TAG) {
DeleteMR<SBF>(u_.sbf);
} else {
LOG(FATAL) << "Unsupported tag " << int(taglen_);
}
@ -1015,6 +1033,9 @@ size_t CompactObj::MallocUsed() const {
return u_.small_str.MallocUsed();
}
if (taglen_ == SBF_TAG) {
return 0; // TODO: to track SBF memory utilization.
}
LOG(DFATAL) << "should not reach";
return 0;
}