mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 10:25:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

opt: Slightly less allocations in OpaqueObjLoader::CreateHMap (#1227)

Browse source 
Moves the temporary variable outside the loop so we can reuse the buffer.

Signed-off-by: Roy Jacobson <roy@dragonflydb.io>
This commit is contained in:
Roy Jacobson 2023-05-17 11:44:46 +03:00 • committed by GitHub
parent 9ff8cdf905
commit a1a8acb155
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/server/rdb_load.cc
View file

@ -596,12 +596,13 @@ void RdbLoaderBase::OpaqueObjLoader::CreateHMap(const LoadTrace* ltrace) {
StringMap* string_map = new StringMap;
auto cleanup = absl::MakeCleanup([&] { delete string_map; });
std::string key;
string_map->Reserve(len);
for (const auto& seg : ltrace->arr) {
for (size_t i = 0; i < seg.size(); i += 2) {
// ToSV may reference an internal buffer, therefore we can use only before the
// next call to ToSV. To workaround, I copy the key to string.
string key(ToSV(seg[i].rdb_var));
// next call to ToSV. To workaround, copy the key locally.
key = ToSV(seg[i].rdb_var);
string_view val = ToSV(seg[i + 1].rdb_var);
if (ec_)