From a40b5063e2fe72314d77aacabbacc17534f6e7fb Mon Sep 17 00:00:00 2001 From: Kostas Kyrimis Date: Wed, 5 Feb 2025 10:11:04 +0200 Subject: [PATCH] fix: consume parser error on dfly load (#4556) * fix dcheck crash on dfly load * fix dfly load with more than required arguments Signed-off-by: kostas --- src/server/dflycmd.cc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/server/dflycmd.cc b/src/server/dflycmd.cc index 7415bd03a..f15b4e5e9 100644 --- a/src/server/dflycmd.cc +++ b/src/server/dflycmd.cc @@ -528,11 +528,7 @@ void DflyCmd::Load(CmdArgList args, RedisReplyBuilder* rb, ConnectionContext* cn existing_keys = ServerFamily::LoadExistingKeys::kOverride; } - if (parser.HasNext()) { - parser.Error(); - } - - if (parser.HasError()) { + if (parser.Error() || parser.HasNext()) { return rb->SendError(kSyntaxErr); }