mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 18:35:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

feat(bitops_family): implement bitfield_ro command (#2222)

Browse source 
* add bitfield_ro command
* add parsing test
This commit is contained in:
Kostas Kyrimis 2023-12-01 10:49:47 +02:00 • committed by GitHub
parent d495baba93
commit b53492ece7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/server/bitops_family.cc
View file

@ -1003,7 +1003,7 @@ nonstd::expected<CommonAttributes, std::string> ParseCommonAttr(CmdArgParser* pr
// Parses a list of arguments (without key) to a CommandList.
// Returns the CommandList if the parsing completed succefully or std::string
// to indicate an error
nonstd::expected<CommandList, std::string> ParseToCommandList(CmdArgList args) {
nonstd::expected<CommandList, std::string> ParseToCommandList(CmdArgList args, bool read_only) {
CommandList result;
using nonstd::make_unexpected;
@ -1018,6 +1018,9 @@ nonstd::expected<CommandList, std::string> ParseToCommandList(CmdArgList args) {
using namespace std::string_view_literals;
if (op == "OVERFLOW"sv) {
if (read_only) {
make_unexpected("BITFIELD_RO only supports the GET subcommand");
}
using pol = Overflow::Policy;
auto res = parser.ToUpper().Switch("SAT", pol::SAT, "WRAP", pol::WRAP, "FAIL", pol::FAIL);
if (!parser.HasError()) {
@ -1039,6 +1042,10 @@ nonstd::expected<CommandList, std::string> ParseToCommandList(CmdArgList args) {
continue;
}
if (read_only) {
return make_unexpected("BITFIELD_RO only supports the GET subcommand");
}
auto value = parser.ToUpper().Next<int64_t>();
if (parser.HasError()) {
parser.Error();
@ -1078,13 +1085,13 @@ void SendResults(const std::vector<ResultType>& results, ConnectionContext* cntx
}
}
void BitField(CmdArgList args, ConnectionContext* cntx) {
void BitFieldGeneric(CmdArgList args, bool read_only, ConnectionContext* cntx) {
if (args.size() == 1) {
(*cntx)->SendNullArray();
return;
}
auto key = ArgS(args, 0);
auto maybe_ops_list = ParseToCommandList(args.subspan(1));
auto maybe_ops_list = ParseToCommandList(args.subspan(1), read_only);
if (!maybe_ops_list.has_value()) {
cntx->SendError(maybe_ops_list.error());
@ -1109,9 +1116,12 @@ void BitField(CmdArgList args, ConnectionContext* cntx) {
SendResults(*res, cntx);
}
void BitField(CmdArgList args, ConnectionContext* cntx) {
BitFieldGeneric(args, false, cntx);
}
void BitFieldRo(CmdArgList args, ConnectionContext* cntx) {
cntx->SendError("Not Yet Implemented");
// return BitField(args, cntx);
BitFieldGeneric(args, true, cntx);
}
#pragma GCC diagnostic pop

4
src/server/bitops_family_test.cc
View file

@ -557,6 +557,10 @@ TEST_F(BitOpsFamilyTest, BitFieldParsing) {
ASSERT_THAT(Run({"bitfield", "foo", "set", "u64", "0", "0"}), expected_error);
ASSERT_THAT(Run({"bitfield", "foo", "set", "u65", "0", "0"}), expected_error);
ASSERT_THAT(Run({"bitfield", "foo", "set", "i65", "0", "0"}), expected_error);
expected_error = ErrArg("BITFIELD_RO only supports the GET subcommand");
ASSERT_THAT(Run({"bitfield_ro", "foo", "set", "u1", "0", "0"}), expected_error);
ASSERT_THAT(Run({"bitfield_ro", "foo", "incrby", "i64", "0", "15"}), expected_error);
}
TEST_F(BitOpsFamilyTest, BitFieldCreate) {