mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 10:25:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

chore(reply_builder): add dcheck that each command invocation has rep… (#2067)

Browse source 
* chore(reply_builder): add dcheck that each command invocation has replied
This commit is contained in:
Kostas Kyrimis 2023-10-26 19:44:32 +03:00 • committed by GitHub
parent 1961ff1063
commit b655fc7415
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 42 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

27
src/server/main_service.cc
View file

@ -1047,6 +1047,30 @@ void Service::DispatchCommand(CmdArgList args, facade::ConnectionContext* cntx)
}
}
class ReplyGuard {
public:
ReplyGuard(ConnectionContext* cntx, std::string_view cid_name) {
auto* builder = cntx->reply_builder();
const bool is_script = bool(cntx->conn_state.script_info);
const bool is_one_of =
absl::flat_hash_set<std::string_view>({"REPLCONF", "DFLY", "EXEC", "EVALSHA"})
.contains(cid_name);
const bool should_dcheck = !is_one_of && !is_script;
if (should_dcheck) {
builder->ExpectReply();
}
}
~ReplyGuard() {
if (builder) {
DCHECK(builder->HasReplied());
}
}
private:
RedisReplyBuilder* builder = nullptr;
};
bool Service::InvokeCmd(const CommandId* cid, CmdArgList tail_args, ConnectionContext* cntx,
bool record_stats) {
DCHECK(cid);
@ -1066,6 +1090,9 @@ bool Service::InvokeCmd(const CommandId* cid, CmdArgList tail_args, ConnectionCo
DispatchMonitor(cntx, cid, tail_args);
}
#ifndef NDEBUG
ReplyGuard reply_guard(cntx, cid->name());
#endif
try {
cid->Invoke(tail_args, cntx);
} catch (std::exception& e) {