mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 18:35:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix: Invalid memory access (#2435)

Browse source 
The (subtle) bug is that the previous code uses an `initializer_list` c'tor, which copies the
`string_view` locally. Then it keeps that reference to the `string_view`,
but it goes out of scope in the next line
This commit is contained in:
Shahar Mike 2024-01-17 23:23:44 +02:00 • committed by GitHub
parent d1db48d9d4
commit b66db852f9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/server/db_slice.cc
View file

@ -195,7 +195,7 @@ unsigned PrimeEvictionPolicy::Evict(const PrimeTable::HotspotBuckets& eb, PrimeT
// log the evicted keys to journal. // log the evicted keys to journal.
if (auto journal = db_slice_->shard_owner()->journal(); journal) { if (auto journal = db_slice_->shard_owner()->journal(); journal) {
ArgSlice delete_args{key}; ArgSlice delete_args(&key, 1);
journal->RecordEntry(0, journal::Op::EXPIRED, cntx_.db_index, 1, ClusterConfig::KeySlot(key), journal->RecordEntry(0, journal::Op::EXPIRED, cntx_.db_index, 1, ClusterConfig::KeySlot(key),
make_pair("DEL", delete_args), false); make_pair("DEL", delete_args), false);
} }