cleanups: Remove unused member, rename test, remove unused forward decl. (#1483)

This commit is contained in:
Shahar Mike 2023-06-28 09:41:04 +03:00 committed by GitHub
parent aed01aa5e4
commit bf363661e4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 5 deletions

View file

@ -86,8 +86,6 @@ class ClusterConfig {
ClusterConfig() = default; ClusterConfig() = default;
std::string my_id_;
ClusterShards config_; ClusterShards config_;
// True bits in `my_slots_` indicate that this slot is owned by this node. // True bits in `my_slots_` indicate that this slot is owned by this node.

View file

@ -91,7 +91,7 @@ TEST_F(ClusterConfigTest, ConfigSetOk) {
EXPECT_THAT(config->GetOwnedSlots(), UnorderedElementsAre()); EXPECT_THAT(config->GetOwnedSlots(), UnorderedElementsAre());
} }
TEST_F(ClusterConfigTest, ConfigSetOkWithReplicas) { TEST_F(ClusterConfigTest, ConfigSetOkWithReplica) {
auto config = ClusterConfig::CreateFromConfig( auto config = ClusterConfig::CreateFromConfig(
kMyId, {{.slot_ranges = {{.start = 0, .end = 0x3FFF}}, kMyId, {{.slot_ranges = {{.start = 0, .end = 0x3FFF}},
.master = {.id = "other-master", .ip = "192.168.0.100", .port = 7000}, .master = {.id = "other-master", .ip = "192.168.0.100", .port = 7000},

View file

@ -19,8 +19,6 @@ namespace journal {
struct Entry; struct Entry;
} // namespace journal } // namespace journal
class RdbSerializer;
// ┌────────────────┐ ┌─────────────┐ // ┌────────────────┐ ┌─────────────┐
// │IterateBucketsFb│ │ OnDbChange │ // │IterateBucketsFb│ │ OnDbChange │
// └──────┬─────────┘ └─┬───────────┘ // └──────┬─────────┘ └─┬───────────┘