From c2ee348d2cc63ebddb9b71d77707a02e6ebfea5f Mon Sep 17 00:00:00 2001
From: adiholden <adi@dragonflydb.io>
Date: Fri, 9 Feb 2024 08:10:41 +0200
Subject: [PATCH] fix(server): do not print warning on replica stop/ takeover
 (#2560)

* fix(server): do not print warning on replica stop/ takeover

---------

Signed-off-by: adi_holden <adi@dragonflydb.io>
---
 src/server/replica.cc | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/server/replica.cc b/src/server/replica.cc
index 545f71151..db8b51816 100644
--- a/src/server/replica.cc
+++ b/src/server/replica.cc
@@ -234,9 +234,11 @@ void Replica::MainReplicationFb() {
     else
       ec = ConsumeRedisStream();
 
-    LOG(WARNING) << "Error stable sync with " << server().Description() << " " << ec << " "
-                 << ec.message();
-    state_mask_.fetch_and(R_ENABLED);
+    auto state = state_mask_.fetch_and(R_ENABLED);
+    if (state & R_ENABLED) {  // replication was not stopped.
+      LOG(WARNING) << "Error stable sync with " << server().Description() << " " << ec << " "
+                   << ec.message();
+    }
   }
 
   // Wait for unblocking cleanup to finish.