mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 10:25:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(acl): authentication with UDS socket (#2895)

Browse source 
* disable authentication on UDS socket
* add a test so the bug won't happen again
This commit is contained in:
Kostas Kyrimis 2024-04-12 16:01:12 +03:00 • committed by GitHub
parent 0f613d8f85
commit c2f13993d9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/server/main_service.cc
View file

@ -1506,7 +1506,9 @@ facade::ConnectionContext* Service::CreateContext(util::FiberSocketBase* peer,
facade::Connection* owner) { facade::Connection* owner) {
ConnectionContext* res = new ConnectionContext{peer, owner}; ConnectionContext* res = new ConnectionContext{peer, owner};
if (owner->IsPrivileged() && RequirePrivilegedAuth()) { if (peer->IsUDS()) {
res->req_auth = false;
} else if (owner->IsPrivileged() && RequirePrivilegedAuth()) {
res->req_auth = !GetPassword().empty(); res->req_auth = !GetPassword().empty();
} else if (!owner->IsPrivileged()) { } else if (!owner->IsPrivileged()) {
res->req_auth = !user_registry_.AuthUser("default", ""); res->req_auth = !user_registry_.AuthUser("default", "");

10
tests/dragonfly/connection_test.py
View file

@ -658,6 +658,16 @@ async def test_unix_domain_socket(df_local_factory, tmp_dir):
assert await r.ping() assert await r.ping()
async def test_unix_socket_only(df_local_factory, tmp_dir):
server = df_local_factory.create(proactor_threads=1, port=0, unixsocket="./df.sock")
server._start()
await asyncio.sleep(1)
r = aioredis.Redis(unix_socket_path=tmp_dir / "df.sock")
assert await r.ping()
""" """
Test nested pauses. Executing CLIENT PAUSE should be possible even if another write-pause is active. Test nested pauses. Executing CLIENT PAUSE should be possible even if another write-pause is active.
It should prolong the pause for all current commands. It should prolong the pause for all current commands.