mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-12 10:55:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

chore: Introduce basic deadlock detector for tests (#1896)

Browse source 
Also, fix IOUring dependency issue in tests on non-linux platforms.

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
This commit is contained in:
Roman Gershman 2023-09-20 14:13:22 +03:00 • committed by GitHub
parent f652e09a4a
commit c612a2be67
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 41 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

55
src/server/test_utils.cc
View file

@ -164,6 +164,15 @@ void BaseFamilyTest::SetUp() {
ResetService();
}
void BaseFamilyTest::TearDown() {
CHECK_EQ(NumLocked(), 0U);
ShutdownService();
const TestInfo* const test_info = UnitTest::GetInstance()->current_test_info();
LOG(INFO) << "Finishing " << test_info->name();
}
// Test hook defined in common.cc.
void TEST_InvalidateLockHashTag();
@ -171,20 +180,19 @@ void BaseFamilyTest::ResetService() {
if (service_ != nullptr) {
TEST_InvalidateLockHashTag();
service_->Shutdown();
service_ = nullptr;
delete shard_set;
shard_set = nullptr;
pp_->Stop();
ShutdownService();
}
#ifdef __linux__
if (absl::GetFlag(FLAGS_force_epoll)) {
pp_.reset(fb2::Pool::Epoll(num_threads_));
} else {
pp_.reset(fb2::Pool::IOUring(16, num_threads_));
}
#else
pp_.reset(fb2::Pool::Epoll(num_threads_));
#endif
pp_->Run();
service_ = std::make_unique<Service>(pp_.get());
@ -199,6 +207,28 @@ void BaseFamilyTest::ResetService() {
const TestInfo* const test_info = UnitTest::GetInstance()->current_test_info();
LOG(INFO) << "Starting " << test_info->name();
watchdog_fiber_ = pp_->GetNextProactor()->LaunchFiber([this] {
if (!watchdog_done_.WaitFor(120s)) {
LOG(ERROR) << "Deadlock detected!!!!";
absl::SetFlag(&FLAGS_alsologtostderr, true);
fb2::detail::FiberInterface::PrintAllFiberStackTraces();
}
});
}
void BaseFamilyTest::ShutdownService() {
DCHECK(service_);
service_->Shutdown();
service_.reset();
delete shard_set;
shard_set = nullptr;
watchdog_done_.Notify();
watchdog_fiber_.Join();
pp_->Stop();
}
unsigned BaseFamilyTest::NumLocked() {
@ -214,17 +244,6 @@ unsigned BaseFamilyTest::NumLocked() {
return count;
}
void BaseFamilyTest::TearDown() {
CHECK_EQ(NumLocked(), 0U);
service_->Shutdown();
service_.reset();
pp_->Stop();
const TestInfo* const test_info = UnitTest::GetInstance()->current_test_info();
LOG(INFO) << "Finishing " << test_info->name();
}
void BaseFamilyTest::WaitUntilLocked(DbIndex db_index, string_view key, double timeout) {
auto step = 50us;
auto timeout_micro = chrono::duration_cast<chrono::microseconds>(1000ms * timeout);