mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 18:35:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

feat(server): Tracking memory usage for client tracking table (#2431)

Browse source 
Tracking memory usage for client tracking table using C++ memory resource and polymorphic allocator.
This commit is contained in:
Yue Li 2024-01-17 13:20:23 -08:00 • committed by GitHub
parent e06b736c02
commit d1db48d9d4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 23 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/server/db_slice.cc
View file

@ -249,7 +249,10 @@ SliceEvents& SliceEvents::operator+=(const SliceEvents& o) {
#undef ADD
DbSlice::DbSlice(uint32_t index, bool caching_mode, EngineShard* owner)
: shard_id_(index), caching_mode_(caching_mode), owner_(owner) {
: shard_id_(index),
caching_mode_(caching_mode),
owner_(owner),
client_tracking_map_(owner->memory_resource()) {
db_arr_.emplace_back();
CreateDb(0);
expire_base_[0] = expire_base_[1] = 0;

21
src/server/db_slice.h
View file

@ -4,6 +4,7 @@
#pragma once
#include "core/mi_memory_resource.h"
#include "facade/dragonfly_connection.h"
#include "facade/op_status.h"
#include "server/common.h"
@ -491,8 +492,24 @@ class DbSlice {
}
};
// the table that maps keys to the clients that are tracking them.
absl::flat_hash_map<std::string, absl::flat_hash_set<facade::Connection::WeakRef, Hash>>
// the following type definitions are confusing, and they are for achieving memory
// usage tracking for client_tracking_map_ data structure through C++'s memory resource and
// and polymorphic allocator (new C++ features)
// the declarations below meant to say:
// absl::flat_hash_map<std::string,
// absl::flat_hash_set<facade::Connection::WeakRef, Hash>> client_tracking_map_
using HashSetAllocator = PMR_NS::polymorphic_allocator<facade::Connection::WeakRef>;
using ConnectionHashSet =
absl::flat_hash_set<facade::Connection::WeakRef, Hash,
absl::container_internal::hash_default_eq<facade::Connection::WeakRef>,
HashSetAllocator>;
using AllocatorType = PMR_NS::polymorphic_allocator<std::pair<std::string, ConnectionHashSet>>;
absl::flat_hash_map<std::string, ConnectionHashSet,
absl::container_internal::hash_default_hash<std::string>,
absl::container_internal::hash_default_eq<std::string>, AllocatorType>
client_tracking_map_;
};