mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 02:15:45 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

chore: make per-thread QueueBackpressure objects global (#4482)

Browse source 
Before this PR, QueueBackpressure objects are in fact referenced from other threads in an awkward way via
Connection::WeakRef::EnsureMemoryBudget().

This PR removes the complexities of accessing these objects from foreigh threads.
This commit is contained in:
Roman Gershman 2025-01-20 12:53:36 +02:00 • committed by GitHub
parent b017cdd1a0
commit d2209d9eea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 89 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/server/main_service.cc
View file

@ -778,6 +778,7 @@ Service::~Service() {
void Service::Init(util::AcceptServer* acceptor, std::vector<facade::Listener*> listeners) {
InitRedisTables();
facade::Connection::Init(pp_.size());
config_registry.RegisterSetter<MemoryBytesFlag>(
"maxmemory", [](const MemoryBytesFlag& flag) { max_memory_limit = flag.value; });
@ -800,12 +801,12 @@ void Service::Init(util::AcceptServer* acceptor, std::vector<facade::Listener*>
config_registry.RegisterSetter<uint32_t>("pipeline_queue_limit", [](uint32_t val) {
shard_set->pool()->AwaitBrief(
[val](unsigned, auto*) { facade::Connection::SetMaxQueueLenThreadLocal(val); });
[val](unsigned tid, auto*) { facade::Connection::SetMaxQueueLenThreadLocal(tid, val); });
});
config_registry.RegisterSetter<size_t>("pipeline_buffer_limit", [](size_t val) {
shard_set->pool()->AwaitBrief(
[val](unsigned, auto*) { facade::Connection::SetPipelineBufferLimit(val); });
[val](unsigned tid, auto*) { facade::Connection::SetPipelineBufferLimit(tid, val); });
});
config_registry.RegisterMutable("replica_partial_sync");
@ -910,6 +911,7 @@ void Service::Shutdown() {
// wait for all the pending callbacks to stop.
ThisFiber::SleepFor(10ms);
facade::Connection::Shutdown();
}
optional<ErrorReply> Service::CheckKeysOwnership(const CommandId* cid, CmdArgList args,