mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 18:35:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

feat(cluster): Do not allow node IDs to appear more than once. (#1271)

Browse source
This commit is contained in:
Chaka 2023-05-22 11:09:01 +03:00 • committed by GitHub
parent 7289a83087
commit db5e069412
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 123 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

33
src/server/cluster/cluster_config.cc
View file

@ -36,9 +36,40 @@ ClusterConfig::ClusterConfig(string_view my_id) : my_id_(my_id) {
cluster_enabled = true;
}
bool ClusterConfig::IsConfigValid(const vector<ClusterShard>& new_config) {
namespace {
bool HasValidNodeIds(const ClusterConfig::ClusterShards& new_config) {
absl::flat_hash_set<string_view> nodes;
auto CheckAndInsertNode = [&](string_view node) {
auto [_, inserted] = nodes.insert(node);
return inserted;
};
for (const auto& shard : new_config) {
if (!CheckAndInsertNode(shard.master.id)) {
LOG(WARNING) << "Master " << shard.master.id << " appears more than once";
return false;
}
for (const auto& replica : shard.replicas) {
if (!CheckAndInsertNode(replica.id)) {
LOG(WARNING) << "Replica " << replica.id << " appears more than once";
return false;
}
}
}
return true;
}
} // namespace
bool ClusterConfig::IsConfigValid(const ClusterShards& new_config) {
// Make sure that all slots are set exactly once.
array<bool, tuple_size<decltype(slots_)>::value> slots_found = {};
if (!HasValidNodeIds(new_config)) {
return false;
}
for (const auto& shard : new_config) {
for (const auto& slot_range : shard.slot_ranges) {
if (slot_range.start > slot_range.end) {