mirrors/dragonfly
1
0
Fork 0
mirror of https://github.com/dragonflydb/dragonfly.git synced 2025-05-11 18:35:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix: buffer overrun in GetRandomHex (#4717)

Browse source
This commit is contained in:
Roman Gershman 2025-03-06 15:56:17 +02:00 • committed by GitHub
parent 94d9cf79ef
commit df88b9e1f8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/server/dfly_bench.cc
View file

@ -88,16 +88,18 @@ static string GetRandomHex(size_t len) {
std::string res(len, '\0');
size_t indx = 0;
for (; indx < len; indx += 16) { // 2 chars per byte
for (; indx + 16 <= len; indx += 16) { // 2 chars per byte
absl::numbers_internal::FastHexToBufferZeroPad16(bit_gen(), res.data() + indx);
}
DCHECK_LE(indx, len);
if (indx < len) {
char buf[24];
absl::numbers_internal::FastHexToBufferZeroPad16(bit_gen(), buf);
for (unsigned j = 0; indx < len; indx++, j++) {
res[indx] = buf[j];
for (unsigned j = 0; indx < len;) {
res[indx++] = buf[j++];
}
}