From 3e2ef84d566678ffaa6afa120c6881b558eb2227 Mon Sep 17 00:00:00 2001 From: Jesse Duffield Date: Sat, 30 Sep 2023 19:23:52 +1000 Subject: [PATCH] Ignore deprecation checks in linter This is pretty funny: the staticcheck linter gets mad if we use a field which is marked in a comment as being deprecated. But it tripped on my own comment saying that a field is deprecated in terms of the user config! Obviously we have to make use of this field, otherwise we would just remove it entirely rather than mark it as deprecated, so I'm silencing this lint. I doubt this lint would actually come in handy in other cases (like when using a third party package) and worst case scenario we just end up fixing the problem when we try to upgrade the package and the deprecated field is now gone). --- .golangci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index d9c67792e..258660b62 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -20,7 +20,11 @@ linters: linters-settings: exhaustive: default-signifies-exhaustive: true - + staticcheck: + # SA1019 is for checking that we're not using fields marked as deprecated + # in a comment. It decides this in a loose way so I'm silencing it. Also because + # it's tripping on our own structs. + checks: ["all", "-SA1019"] nakedret: # the gods will judge me but I just don't like naked returns at all max-func-lines: 0