From 4cfa6e0c98a18e0c9fb1bbb410c1ed10ed0c823d Mon Sep 17 00:00:00 2001
From: Stefan Haller <stefan@haller-berlin.de>
Date: Fri, 18 Apr 2025 21:30:24 +0200
Subject: [PATCH] Modernize benchmarks

See https://go.dev/blog/testing-b-loop
---
 pkg/config/app_config_test.go            | 2 +-
 pkg/gui/presentation/graph/graph_test.go | 2 +-
 pkg/utils/formatting_test.go             | 8 ++++----
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/pkg/config/app_config_test.go b/pkg/config/app_config_test.go
index 9f9abc38a..c9199fdc7 100644
--- a/pkg/config/app_config_test.go
+++ b/pkg/config/app_config_test.go
@@ -691,7 +691,7 @@ keybinding:
 `)
 
 func BenchmarkMigrationOnLargeConfiguration(b *testing.B) {
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		_, _ = computeMigratedConfig("path doesn't matter", largeConfiguration)
 	}
 }
diff --git a/pkg/gui/presentation/graph/graph_test.go b/pkg/gui/presentation/graph/graph_test.go
index 39f4400da..5cb4875f5 100644
--- a/pkg/gui/presentation/graph/graph_test.go
+++ b/pkg/gui/presentation/graph/graph_test.go
@@ -548,7 +548,7 @@ func BenchmarkRenderCommitGraph(b *testing.B) {
 		return authors.AuthorStyle(commit.AuthorName)
 	}
 	b.ResetTimer()
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		RenderCommitGraph(commits, "selected", getStyle)
 	}
 }
diff --git a/pkg/utils/formatting_test.go b/pkg/utils/formatting_test.go
index ac2adee5f..37e6702a5 100644
--- a/pkg/utils/formatting_test.go
+++ b/pkg/utils/formatting_test.go
@@ -253,25 +253,25 @@ func TestRenderDisplayStrings(t *testing.T) {
 }
 
 func BenchmarkStringWidthAsciiOriginal(b *testing.B) {
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		runewidth.StringWidth("some ASCII string")
 	}
 }
 
 func BenchmarkStringWidthAsciiOptimized(b *testing.B) {
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		StringWidth("some ASCII string")
 	}
 }
 
 func BenchmarkStringWidthNonAsciiOriginal(b *testing.B) {
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		runewidth.StringWidth("some non-ASCII string 🍉")
 	}
 }
 
 func BenchmarkStringWidthNonAsciiOptimized(b *testing.B) {
-	for i := 0; i < b.N; i++ {
+	for b.Loop() {
 		StringWidth("some non-ASCII string 🍉")
 	}
 }