Validate keys of custom commands

This commit is contained in:
Stefan Haller 2025-02-16 16:19:15 +01:00
parent a5f78d3222
commit 5979b40546
2 changed files with 38 additions and 0 deletions

View file

@ -22,6 +22,9 @@ func (config *UserConfig) Validate() error {
if err := validateKeybindings(config.Keybinding); err != nil {
return err
}
if err := validateCustomCommands(config.CustomCommands); err != nil {
return err
}
return nil
}
@ -79,3 +82,20 @@ func validateKeybindings(keybindingConfig KeybindingConfig) error {
return nil
}
func validateCustomCommandKey(key string) error {
if !isValidKeybindingKey(key) {
return fmt.Errorf("Unrecognized key '%s' for custom command. For permitted values see %s",
key, constants.Links.Docs.CustomKeybindings)
}
return nil
}
func validateCustomCommands(customCommands []CustomCommand) error {
for _, customCommand := range customCommands {
if err := validateCustomCommandKey(customCommand.Key); err != nil {
return err
}
}
return nil
}

View file

@ -56,6 +56,24 @@ func TestUserConfigValidate_enums(t *testing.T) {
{value: "1,2,3,4,5,6", valid: false},
},
},
{
name: "Custom command keybinding",
setup: func(config *UserConfig, value string) {
config.CustomCommands = []CustomCommand{
{
Key: value,
Command: "echo 'hello'",
},
}
},
testCases: []testCase{
{value: "", valid: true},
{value: "<disabled>", valid: true},
{value: "q", valid: true},
{value: "<c-c>", valid: true},
{value: "invalid_value", valid: false},
},
},
}
for _, s := range scenarios {