mirrors/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-05-11 04:15:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unused keybinding handler

Browse source 
It's never called, the binding ListController.HandleGotoBottom wins.

The functionality of loading more commits is implemented by GetOnFocus, and this
way it works not only for '>', but also for other navigation keys like page
down.
This commit is contained in:
Stefan Haller 2025-05-08 14:56:19 +02:00
parent e6bd9d0ae6
commit b0f6e68211
1 changed files with 0 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

22
pkg/gui/controllers/local_commits_controller.go
View file

@ -207,14 +207,6 @@ func (self *LocalCommitsController) GetKeybindings(opts types.KeybindingsOpts) [
Description: self.c.Tr.MarkAsBaseCommit, Description: self.c.Tr.MarkAsBaseCommit,
Tooltip: self.c.Tr.MarkAsBaseCommitTooltip, Tooltip: self.c.Tr.MarkAsBaseCommitTooltip,
}, },
// overriding this navigation keybinding because we might need to load
// more commits on demand
{
Key: opts.GetKey(opts.Config.Universal.GotoBottom),
Handler: self.gotoBottom,
Description: self.c.Tr.GotoBottom,
Tag: "navigation",
},
} }
for _, binding := range outsideFilterModeBindings { for _, binding := range outsideFilterModeBindings {
@ -1154,20 +1146,6 @@ func (self *LocalCommitsController) openSearch() error {
return self.c.Helpers().Search.OpenSearchPrompt(self.context()) return self.c.Helpers().Search.OpenSearchPrompt(self.context())
} }
func (self *LocalCommitsController) gotoBottom() error {
// we usually lazyload these commits but now that we're jumping to the bottom we need to load them now
if self.context().GetLimitCommits() {
self.context().SetLimitCommits(false)
if err := self.c.Refresh(types.RefreshOptions{Mode: types.SYNC, Scope: []types.RefreshableView{types.COMMITS}}); err != nil {
return err
}
}
self.context().SetSelectedLineIdx(self.context().Len() - 1)
return nil
}
func (self *LocalCommitsController) handleOpenLogMenu() error { func (self *LocalCommitsController) handleOpenLogMenu() error {
return self.c.Menu(types.CreateMenuOptions{ return self.c.Menu(types.CreateMenuOptions{
Title: self.c.Tr.LogMenuTitle, Title: self.c.Tr.LogMenuTitle,