mirrors/lazygit
1
0
Fork 0
mirror of https://github.com/jesseduffield/lazygit.git synced 2025-05-11 04:15:48 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: use correct executable name depending on OS #4269

Browse source
This commit is contained in:
Casper Verhaar 2025-02-15 21:23:11 +01:00
parent 01eece3737
commit e776dc1f3c
1 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

14
pkg/updates/updates.go
View file

@ -219,6 +219,14 @@ func (u *Updater) zipExtension() string {
return "tar.gz" return "tar.gz"
} }
func (u *Updater) executableName() string {
if runtime.GOOS == "windows" {
return "lazygit.exe"
}
return "lazygit"
}
// example: https://github.com/jesseduffield/lazygit/releases/download/v0.1.73/lazygit_0.1.73_Darwin_x86_64.tar.gz // example: https://github.com/jesseduffield/lazygit/releases/download/v0.1.73/lazygit_0.1.73_Darwin_x86_64.tar.gz
func (u *Updater) getBinaryUrl(newVersion string) string { func (u *Updater) getBinaryUrl(newVersion string) string {
url := fmt.Sprintf( url := fmt.Sprintf(
@ -282,8 +290,10 @@ func (u *Updater) downloadAndInstall(rawUrl string) error {
return err return err
} }
executableName := u.executableName()
u.Log.Info("untarring tarball/unzipping zip file") u.Log.Info("untarring tarball/unzipping zip file")
err = u.OSCommand.Cmd.New([]string{"tar", "-zxf", zipPath, "lazygit"}).Run() err = u.OSCommand.Cmd.New([]string{"tar", "-zxf", zipPath, executableName}).Run()
if err != nil { if err != nil {
return err return err
} }
@ -291,7 +301,7 @@ func (u *Updater) downloadAndInstall(rawUrl string) error {
// the `tar` terminal cannot store things in a new location without permission // the `tar` terminal cannot store things in a new location without permission
// so it creates it in the current directory. As such our path is fairly simple. // so it creates it in the current directory. As such our path is fairly simple.
// You won't see it because it's gitignored. // You won't see it because it's gitignored.
tempLazygitFilePath := "lazygit" tempLazygitFilePath := executableName
u.Log.Infof("Path to temp binary is %s", tempLazygitFilePath) u.Log.Infof("Path to temp binary is %s", tempLazygitFilePath)