lazygit/pkg/gui/controllers/helpers
Stefan Haller 3a30211099 Don't preserve commit message when it's unchanged from initial message
Sometimes we populate the commit message panel with a pre-created commit
message. The two cases where this happens is:
- you type `w` to commit, in which case we put the skipHookPrefix in the subject
- you have a commitPrefix pattern, in which case we match it against the branch
  name and populate the subject with the replacement string if it matches

In either case, if you have a preserved commit message, we use that.

Now, when you use either of these and then cancel, we preserve that initial,
unchanged message and reuse it the next time you commit. This has two problems:
it strips spaces, which is a problem for the commitPrefix patterns, which often
end with a space. And also, when you change your config to experiment with
commitPrefix patterns, the change seemingly doesn't take effect, which can be
very confusing.

To fix both of these problems, only preserve the commit message when it is not
identical to the initial message.
2024-12-23 12:28:52 +01:00
..
amend_helper.go Improve prompts when amending commits 2023-09-01 18:55:16 +02:00
app_status_helper.go Change direct access to Common.UserConfig to a getter 2024-08-18 10:24:52 +02:00
bisect_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
branches_helper.go Allow deleting a range selection of branches 2024-12-01 10:59:54 +01:00
cherry_pick_helper.go Allow pasting commits more than once 2024-10-13 16:55:54 +02:00
commits_helper.go Don't preserve commit message when it's unchanged from initial message 2024-12-23 12:28:52 +01:00
commits_helper_test.go Remove hard line breaks when rewording commits 2024-03-09 10:00:44 +01:00
confirmation_helper.go Return arrays with line indices from WrapViewLinesToWidth 2024-12-23 12:24:09 +01:00
credentials_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
diff_helper.go Cleanup: move adding --ignore-all-space arg to DiffCmdObj 2024-12-01 13:01:15 +01:00
files_helper.go Remove calls to Error() 2024-04-18 10:10:30 +02:00
fixup_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
fixup_helper_test.go Also return hunks with only added lines from parseDiff 2024-06-01 08:31:18 +02:00
gpg_helper.go Change direct access to Common.UserConfig to a getter 2024-08-18 10:24:52 +02:00
helpers.go Add command to find base commit for creating a fixup 2024-01-10 09:11:40 +01:00
host_helper.go Change direct access to Common.UserConfig to a getter 2024-08-18 10:24:52 +02:00
inline_status_helper.go Remove return value of HandleRender 2024-09-06 08:45:48 +02:00
merge_and_rebase_helper.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
merge_conflicts_helper.go Remove return value of IContextMgr.Push/Pop et. al. 2024-09-06 08:45:48 +02:00
mode_helper.go Return error from RefreshOptions.Then 2024-04-18 10:10:30 +02:00
patch_building_helper.go Handle wrapped lines in patch explorer state 2024-12-23 12:24:09 +01:00
record_directory_helper.go split context common from helper common 2023-04-30 13:19:53 +10:00
refresh_helper.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
refs_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
repos_helper.go Remove ErrorMsg 2024-04-18 10:10:30 +02:00
search_helper.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
snake_helper.go Bump gocui and adapt lazygit code 2024-12-01 10:40:08 +01:00
staging_helper.go Handle wrapped lines in patch explorer state 2024-12-23 12:24:09 +01:00
sub_commits_helper.go Get rid of error return value of PostRefreshUpdate and a few related ones 2024-10-13 16:55:54 +02:00
suggestions_helper.go pkg/gui: Allow user to select remote and branch when creating a PR 2024-11-23 11:52:21 +11:00
tags_helper.go Remove return value of OpenCommitMessagePanel 2024-09-06 08:45:48 +02:00
update_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
upstream_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00
upstream_helper_test.go Standardise on using lo for slice functions 2023-07-30 18:51:23 +10:00
view_helper.go standardise helper args 2023-04-30 13:19:53 +10:00
window_arrangement_helper.go Change direct access to Common.UserConfig to a getter 2024-08-18 10:24:52 +02:00
window_arrangement_helper_test.go Add user config expandedSidePanelWeight 2024-06-01 08:21:23 +02:00
window_helper.go Replace CurrentContext() with Context().Current() 2024-08-17 11:14:51 +02:00
working_tree_helper.go Remove return value of OpenCommitMessagePanel 2024-09-06 08:45:48 +02:00
worktree_helper.go Remove return value of Alert/Confirm/Prompt 2024-09-06 08:45:48 +02:00