mirror of
https://github.com/jesseduffield/lazygit.git
synced 2025-05-11 20:36:03 +02:00
8b99a3c949
The rebase.updateRefs feature of git is very useful to rebase a stack of branches and keep everything nicely stacked; however, it is usually in the way when you make a copy of a branch and want to rebase it "away" from the original branch in some way or other. For example, the original branch might sit on main, and you want to rebase the copy onto devel to see if things still compile there. Or you want to do some heavy history rewriting experiments on the copy, but keep the original branch in case the experiments fail. Or you want to split a branch in two because it contains two unrelated sets of changes; so you make a copy, and drop half of the commits from the copy, then check out the original branch and drop the other half of the commits from it. In all these cases, git's updateRefs feature insists on moving the original branch along with the copy in the first rebase that you make on the copy. I think this is a bug in git, it should create update-ref todos only for branches that point into the middle of your branch (because only then do they form a stack), not when they point at the head (because then it's a copy). I had a long discussion about this on the git mailing list [1], but people either don't agree or don't care enough. So we fix this on our side: whenever we start a rebase for whatever reason, be it interactive, non-interactive, or behind-the-scenes, we drop any update-ref todos that are at the very top of the todo list, which fixes all the above-mentioned scenarios nicely. I will admit that there's one scenario where git's behavior is the desired one, and the fix in this PR makes it worse: when you create a new branch off of an existing one, with the intention of creating a stack of branches, but before you make the first commit on the new branch you realize some problem with the first branch (e.g. a commit that needs to be reworded or dropped). It this case you do want both branches to be affected by the change. In my experience this scenario is much rarer than the other ones that I described above, and it's also much easier to recover from: just check out the other branch again and hard-reset it to the rebased one. [1] https://public-inbox.org/git/354f9fed-567f-42c8-9da9-148a5e223022@haller-berlin.de/ |
||
|---|---|---|
| .. | ||
| bisect.go | ||
| bisect_info.go | ||
| blame.go | ||
| branch.go | ||
| branch_loader.go | ||
| branch_loader_test.go | ||
| branch_test.go | ||
| commit.go | ||
| commit_file_loader.go | ||
| commit_file_loader_test.go | ||
| commit_loader.go | ||
| commit_loader_test.go | ||
| commit_test.go | ||
| common.go | ||
| config.go | ||
| custom.go | ||
| deps_test.go | ||
| diff.go | ||
| file.go | ||
| file_loader.go | ||
| file_loader_test.go | ||
| file_test.go | ||
| flow.go | ||
| flow_test.go | ||
| git_command_builder.go | ||
| git_command_builder_test.go | ||
| patch.go | ||
| rebase.go | ||
| rebase_test.go | ||
| reflog_commit_loader.go | ||
| reflog_commit_loader_test.go | ||
| remote.go | ||
| remote_loader.go | ||
| repo_paths.go | ||
| repo_paths_test.go | ||
| stash.go | ||
| stash_loader.go | ||
| stash_loader_test.go | ||
| stash_test.go | ||
| status.go | ||
| submodule.go | ||
| sync.go | ||
| sync_test.go | ||
| tag.go | ||
| tag_loader.go | ||
| tag_loader_test.go | ||
| version.go | ||
| version_test.go | ||
| working_tree.go | ||
| working_tree_test.go | ||
| worktree.go | ||
| worktree_loader.go | ||
| worktree_loader_test.go | ||