mirror of
https://github.com/ollama/ollama.git
synced 2025-05-11 18:36:41 +02:00
360 lines
16 KiB
Go
360 lines
16 KiB
Go
package server
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
|
|
"github.com/ollama/ollama/api"
|
|
"github.com/ollama/ollama/template"
|
|
)
|
|
|
|
func readFile(t *testing.T, base, name string) *bytes.Buffer {
|
|
t.Helper()
|
|
|
|
bts, err := os.ReadFile(filepath.Join(base, name))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
return bytes.NewBuffer(bts)
|
|
}
|
|
|
|
func TestParseToolCalls(t *testing.T) {
|
|
p := filepath.Join("testdata", "tools")
|
|
t1 := api.ToolCall{
|
|
Function: api.ToolCallFunction{
|
|
Name: "get_current_weather",
|
|
Arguments: api.ToolCallFunctionArguments{
|
|
"format": "fahrenheit",
|
|
"location": "San Francisco, CA",
|
|
},
|
|
},
|
|
}
|
|
t2 := api.ToolCall{
|
|
Function: api.ToolCallFunction{
|
|
Name: "get_current_weather",
|
|
Arguments: api.ToolCallFunctionArguments{
|
|
"format": "celsius",
|
|
"location": "Toronto, Canada",
|
|
},
|
|
},
|
|
}
|
|
|
|
cases := []struct {
|
|
name string
|
|
model string
|
|
output string
|
|
expectedToolCall []api.ToolCall
|
|
expectedTokens string
|
|
}{
|
|
{
|
|
name: "mistral malformed json with tool calls prefix",
|
|
model: "mistral",
|
|
output: `[TOOL_CALLS] [{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_curren}]`,
|
|
expectedToolCall: []api.ToolCall{},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "mistral multiple tool calls without prefix",
|
|
model: "mistral",
|
|
output: `[{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]`,
|
|
expectedToolCall: []api.ToolCall{t1, t2},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "mistral tool calls with text between no prefix",
|
|
model: "mistral",
|
|
output: `[{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]
|
|
model outputs more tokens here and then [{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]`,
|
|
expectedToolCall: []api.ToolCall{t1, t2},
|
|
expectedTokens: `model outputs more tokens here and then [{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]`,
|
|
},
|
|
{
|
|
name: "mistral valid json with tool calls prefix",
|
|
model: "mistral",
|
|
output: `[TOOL_CALLS] [{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]`,
|
|
expectedToolCall: []api.ToolCall{t1, t2},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "mistral multiple tool calls with text between and prefix",
|
|
model: "mistral",
|
|
output: `[TOOL_CALLS] [{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]
|
|
model outputs more tokens here and then [{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]`,
|
|
expectedToolCall: []api.ToolCall{t1, t2, t1, t2},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "mistral incomplete json with tool calls prefix",
|
|
model: "mistral",
|
|
output: `[TOOL_CALLS] [{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, `,
|
|
expectedToolCall: []api.ToolCall{},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "mistral invalid tool call with explanatory text no prefix",
|
|
model: "mistral",
|
|
output: `I'm not aware of that information. However, I can suggest searching for the weather using the "get_current_weather" function:
|
|
|
|
[{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]`,
|
|
expectedToolCall: []api.ToolCall{},
|
|
expectedTokens: `I'm not aware of that information. However, I can suggest searching for the weather using the "get_current_weather" function: [{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]`,
|
|
},
|
|
{
|
|
name: "mistral tool calls without prefix",
|
|
model: "mistral",
|
|
output: `[{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]`,
|
|
expectedToolCall: []api.ToolCall{t1, t2},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "command r plus tool calls with json block format",
|
|
model: "command-r-plus",
|
|
output: "Action: ```json" + `
|
|
[
|
|
{
|
|
"tool_name": "get_current_weather",
|
|
"parameters": {
|
|
"format": "fahrenheit",
|
|
"location": "San Francisco, CA"
|
|
}
|
|
},
|
|
{
|
|
"tool_name": "get_current_weather",
|
|
"parameters": {
|
|
"format": "celsius",
|
|
"location": "Toronto, Canada"
|
|
}
|
|
}
|
|
]
|
|
` + "```",
|
|
expectedToolCall: []api.ToolCall{t1, t2},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "firefunction tool calls with functools prefix",
|
|
model: "firefunction",
|
|
output: ` functools[{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]`,
|
|
expectedToolCall: []api.ToolCall{t1, t2},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "llama3 groq single tool call with xml tags",
|
|
model: "llama3-groq-tool-use",
|
|
output: `<tool_call>
|
|
{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}}
|
|
</tool_call>`,
|
|
expectedToolCall: []api.ToolCall{t1},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "xlam tool calls with wrapper object",
|
|
model: "xlam",
|
|
output: `{"tool_calls": [{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}},{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]}`,
|
|
expectedToolCall: []api.ToolCall{t1, t2},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "qwen2.5-coder single tool call with prefix",
|
|
model: "qwen2.5-coder",
|
|
output: `<tool_call>{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}}</tool_call>`,
|
|
expectedToolCall: []api.ToolCall{t1},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "qwen2.5-coder multiple tool calls with and without prefix",
|
|
model: "qwen2.5-coder",
|
|
output: `{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}} <tool_call>{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}}</tool_call> <tool_call>{"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}</tool_call>`,
|
|
expectedToolCall: []api.ToolCall{t1, t1, t2},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "qwen2.5-coder multiple tool calls without prefix",
|
|
model: "qwen2.5-coder",
|
|
output: `[{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}}, {"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}]`,
|
|
expectedToolCall: []api.ToolCall{t1, t2},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "qwen2.5-coder plain text response no tool calls",
|
|
model: "qwen2.5-coder",
|
|
output: "The weather in San Francisco, CA is 70°F and in Toronto, Canada is 20°C.",
|
|
expectedToolCall: []api.ToolCall{},
|
|
expectedTokens: "The weather in San Francisco, CA is 70°F and in Toronto, Canada is 20°C.",
|
|
},
|
|
{
|
|
name: "qwen2.5-coder tool calls with trailing text",
|
|
model: "qwen2.5-coder",
|
|
output: `[{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}}, {"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}] some tokens after call`,
|
|
expectedToolCall: []api.ToolCall{t1, t2},
|
|
expectedTokens: "some tokens after call",
|
|
},
|
|
{
|
|
name: "qwen2.5 tool calls with prefix and trailing text",
|
|
model: "qwen2.5-coder",
|
|
output: `<tool_call> [{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}}, {"name": "get_current_weather", "arguments": {"format":"celsius","location":"Toronto, Canada"}}] </tool_call> some tokens after call`,
|
|
expectedToolCall: []api.ToolCall{t1, t2},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "qwen3 tool call with think prefix and tool prefix (sent as a single token)",
|
|
model: "qwen3",
|
|
output: `<think>Okay, let me think what tool we should use...</think><tool_call>{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}}</tool_call>`,
|
|
expectedToolCall: []api.ToolCall{t1},
|
|
expectedTokens: "<think>Okay, let me think what tool we should use...</think>",
|
|
},
|
|
{
|
|
name: "qwen3 tool call with think prefix, tool prefix, and whitespace (sent as separate tokens)",
|
|
model: "qwen3",
|
|
output: `<think>Okay, let me think what tool we should use...</think> <tool_call> {"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}} </tool_call>`,
|
|
expectedToolCall: []api.ToolCall{t1},
|
|
expectedTokens: "<think>Okay, let me think what tool we should use...</think>",
|
|
},
|
|
{
|
|
name: "qwen3 empty think prefix without tool prefix and invalid tool call",
|
|
model: "qwen3",
|
|
output: `<think></think>{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}} </tool_call>`,
|
|
expectedToolCall: []api.ToolCall{},
|
|
expectedTokens: `<think></think>{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}} </tool_call>`,
|
|
},
|
|
{
|
|
name: "qwen3 empty think prefix with tool prefix and valid tool call",
|
|
model: "qwen3",
|
|
output: `<think></think><tool_call>{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}} </tool_call>`,
|
|
expectedToolCall: []api.ToolCall{t1},
|
|
expectedTokens: `<think></think>`,
|
|
},
|
|
{
|
|
name: "qwen3 invalid tool call with fake tool prefix (single rune suffix match)",
|
|
model: "qwen3",
|
|
output: `<think></think>< fakeout{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}} </tool_call>`,
|
|
expectedToolCall: []api.ToolCall{},
|
|
expectedTokens: `<think></think>< fakeout{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}} </tool_call>`,
|
|
},
|
|
{
|
|
name: "qwen3 invalid tool call with partial tool prefix (multiple rune suffix match)",
|
|
model: "qwen3",
|
|
output: `<think></think><tool_c fakeout{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}} </tool_call>`,
|
|
expectedToolCall: []api.ToolCall{},
|
|
expectedTokens: `<think></think><tool_c fakeout{"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}} </tool_call>`,
|
|
},
|
|
{
|
|
name: "qwen3 invalid tool call with malformed tool prefix",
|
|
model: "qwen3",
|
|
output: `<think></think><tool_cfakeout {"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}} </tool_call>`,
|
|
expectedToolCall: []api.ToolCall{},
|
|
expectedTokens: `<think></think><tool_cfakeout {"name": "get_current_weather", "arguments": {"format":"fahrenheit","location":"San Francisco, CA"}} </tool_call>`,
|
|
},
|
|
{
|
|
name: "llama3.2 valid tool call without prefix",
|
|
model: "llama3.2",
|
|
output: `{"name": "get_current_weather", "parameters": {"format":"fahrenheit","location":"San Francisco, CA"}}`,
|
|
expectedToolCall: []api.ToolCall{t1},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "llama3.2 incomplete tool call without prefix",
|
|
model: "llama3.2",
|
|
output: `{"name": "get_current_weather", "parameters": {"format":"fahrenheit","location":"San Francisco, `,
|
|
expectedToolCall: []api.ToolCall{},
|
|
expectedTokens: "",
|
|
},
|
|
{
|
|
name: "llama3.2 tool call with leading text",
|
|
model: "llama3.2",
|
|
output: `some non json text{"name": "get_current_weather", "parameters": {"format":"fahrenheit","location":"San Francisco, CA"}}`,
|
|
expectedToolCall: []api.ToolCall{},
|
|
expectedTokens: `some non json text{"name": "get_current_weather", "parameters": {"format":"fahrenheit","location":"San Francisco, CA"}}`,
|
|
},
|
|
{
|
|
name: "llama3.2 tool call with invalid tool prefix (no prefix in template)",
|
|
model: "llama3.2",
|
|
output: `<tool_call>{"name": "get_current_weather", "parameters": {"format":"fahrenheit","location":"San Francisco, CA"}}`,
|
|
expectedToolCall: []api.ToolCall{},
|
|
expectedTokens: `<tool_call>{"name": "get_current_weather", "parameters": {"format":"fahrenheit","location":"San Francisco, CA"}}`,
|
|
},
|
|
}
|
|
|
|
var tools []api.Tool
|
|
if err := json.Unmarshal(readFile(t, p, "tools.json").Bytes(), &tools); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
var messages []api.Message
|
|
if err := json.Unmarshal(readFile(t, p, "messages.json").Bytes(), &messages); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
for _, tt := range cases {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
tmpl, err := template.Parse(readFile(t, p, fmt.Sprintf("%s.gotmpl", tt.model)).String())
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
t.Run("template", func(t *testing.T) {
|
|
actual := &bytes.Buffer{} // Create new buffer for each test
|
|
if err := tmpl.Execute(actual, template.Values{Tools: tools, Messages: messages}); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if diff := cmp.Diff(actual.String(), readFile(t, p, fmt.Sprintf("%s.out", tt.model)).String()); diff != "" {
|
|
t.Errorf("mismatch (-got +want):\n%s", diff)
|
|
}
|
|
})
|
|
|
|
t.Run("parse", func(t *testing.T) {
|
|
m := &Model{Template: tmpl}
|
|
tp := NewToolParser(m)
|
|
got := []api.ToolCall{}
|
|
var gotTokens strings.Builder
|
|
|
|
tokens := strings.Fields(tt.output)
|
|
for _, tok := range tokens {
|
|
add := true
|
|
s := " " + tok
|
|
|
|
if !tp.Done {
|
|
toolCalls, leftover := tp.ParseToolCalls(s)
|
|
switch tp.ParserState {
|
|
case ToolCallFound:
|
|
got = append(got, toolCalls...)
|
|
add = false
|
|
case ToolCallSendTokens:
|
|
gotTokens.WriteString(s)
|
|
add = false
|
|
case ToolCallAccumulate:
|
|
add = false
|
|
case ToolCallSendPartial:
|
|
t.Log("send partial", "leftover", leftover)
|
|
gotTokens.WriteString(" " + leftover)
|
|
add = false
|
|
}
|
|
}
|
|
if add {
|
|
gotTokens.WriteString(s)
|
|
}
|
|
}
|
|
|
|
// Compare tool calls if we expect any
|
|
if diff := cmp.Diff(got, tt.expectedToolCall); diff != "" {
|
|
t.Errorf("tool calls mismatch (-got +want):\n%s", diff)
|
|
}
|
|
|
|
// Compare tokens if we expect any
|
|
stripped := strings.TrimSpace(gotTokens.String())
|
|
if diff := cmp.Diff(stripped, tt.expectedTokens); diff != "" {
|
|
t.Log("actualTokens", stripped, "expectedTokens", tt.expectedTokens)
|
|
t.Errorf("tokens mismatch (-got +want):\n%s", diff)
|
|
}
|
|
})
|
|
})
|
|
}
|
|
}
|